Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(200)

Issue 1414343008: DEPS: Sync Git subtree mirrors instead of symlinking into chromium/src (Closed)

Created:
5 years, 1 month ago by kjellander_webrtc
Modified:
4 years ago
CC:
aluebs-webrtc, Andrew MacDonald, bjornv1, hlundin-webrtc, kwiberg-webrtc, mflodman, niklas.enbom, peah-webrtc, perkj_webrtc, qiang.lu, the sun, stefan-webrtc, tlegrand-webrtc, tterriberry_mozilla.com, webrtc-reviews_webrtc.org, yujie_mao (webrtc)
Base URL:
https://chromium.googlesource.com/external/webrtc.git@master
Target Ref:
refs/heads/master
Project:
webrtc
Visibility:
Public.

Description

DEPS: Sync Git subtree mirrors instead of symlinking into chromium/src This changes the way we pull in dependencies WebRTC shares with Chromium. The base, build, tools and third_party directories from Chromium are now synced as Git subtree mirrors in the DEPS file. All symlinks to directories that were previously created by the setup_links.py are replaced with proper DEPS entries. One downside with this solution is that we get a lot of directories in tools/ and third_party/ that we currently don't use. Going forward it might be possible to improve this but as long as the BUILD.gn files are stored in the Chromium repo rather at each dependency's repo, this will be very cumbersome. The DEPS file will be kept auto-rolled by the script in https://chromium.googlesource.com/external/webrtc/+/master/tools-webrtc/autoroller/roll_deps.py which is periodically executed by a bot. This change brings back the Google Play Services download for Android, which displays a license confirmation dialog to the user at the first sync. By running it as a proper hook instead of inside sync_chromium.py, the problems with that the interactive prompt gets hidden/stuck should be fixed (now the behavior is identical to Chromium). Some measurements on the size savings for a clean, newly created checkout: Linux: 15GB -> 6.4GB (-8.6GB) Linux (with Android): 25 GB -> 16 GB (-9GB). 8.4GB of this is Android SDK+NDK. Mac (with iOS): 14 GB -> 5.6GB (-8.4GB) Note that for all of the above, 1GB is occupied by the resources/ dir. BUG=webrtc:5006, webrtc:5578 NOTRY=True R=agable@chromium.org, henrika@webrtc.org, iannucci@chromium.org Review-Url: https://codereview.webrtc.org/1414343008 . Cr-Commit-Position: refs/heads/master@{#15754} Committed: https://chromium.googlesource.com/external/webrtc/+/177567c518b121731e507e9b9c4049c4dc96e4c8

Patch Set 1 : Updated #

Patch Set 2 : DEPS: Sync Git subtree mirrors instead of symlinking into chromium/src #

Patch Set 3 : Properly configures with ubsan and msan #

Patch Set 4 : Updated revisions and fixed incorrect opus/src dep #

Patch Set 5 : Rebased DEPS #

Patch Set 6 : Rebased and updated #

Patch Set 7 : Rebased #

Patch Set 8 : Rebased #

Patch Set 9 : Restored clang_format_merge_driver hook #

Patch Set 10 : Added patched-yasm dependency #

Patch Set 11 : Rebased again #

Patch Set 12 : Fix incorrect base Git URL #

Patch Set 13 : Rebased #

Patch Set 14 : Added third_party/openh264/src #

Patch Set 15 : Fix Android #

Patch Set 16 : Adding Android dependencies #

Patch Set 17 : Added libFuzzer and moved yasm to Win condition. #

Patch Set 18 : Rebased (PS 16 and 17 has full trybot coverage) #

Total comments: 2

Patch Set 19 : Updated PRESUBMIT rules #

Patch Set 20 : Rebased #

Patch Set 21 : Rebase + fixed tests #

Patch Set 22 : Rebased #

Unified diffs Side-by-side diffs Delta from patch set Stats (+157 lines, -945 lines) Patch
M .gitignore View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 1 chunk +2 lines, -105 lines 0 comments Download
M DEPS View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 4 chunks +131 lines, -24 lines 0 comments Download
M PRESUBMIT.py View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 1 chunk +2 lines, -19 lines 0 comments Download
D chromium/.gclient View 1 chunk +0 lines, -23 lines 0 comments Download
D chromium/OWNERS View 1 chunk +0 lines, -1 line 0 comments Download
D chromium/README View 1 chunk +0 lines, -5 lines 0 comments Download
D setup_links.py View 1 2 3 4 5 6 7 8 9 10 1 chunk +0 lines, -517 lines 0 comments Download
D sync_chromium.py View 1 1 chunk +0 lines, -191 lines 0 comments Download
M tools-webrtc/autoroller/roll_deps.py View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 9 chunks +18 lines, -47 lines 0 comments Download
M tools-webrtc/autoroller/unittests/roll_deps_test.py View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 3 chunks +3 lines, -12 lines 0 comments Download
M tools-webrtc/autoroller/unittests/testdata/DEPS View 1 2 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 40 (29 generated)
kjellander_webrtc
Robbie, all in our team that have any idea about this are OOO this week. ...
4 years ago (2016-12-20 20:51:58 UTC) #19
kjellander_webrtc
agable can you see if you can figure out any dangers with this? Robbie is ...
4 years ago (2016-12-20 20:54:07 UTC) #21
agable
This LGTM % two comments: * one in-line * there are a ton of new ...
4 years ago (2016-12-20 21:03:13 UTC) #22
kjellander_webrtc
On 2016/12/20 21:03:13, agable wrote: > This LGTM % two comments: > * one in-line ...
4 years ago (2016-12-21 07:39:21 UTC) #23
iannucci
fwiw, this lgtm too. I think without the autoroller script this would be infeasible to ...
4 years ago (2016-12-21 09:20:06 UTC) #24
kjellander_webrtc
Thanks for the reviews! I don't think it's unreasonable to rely on a script for ...
4 years ago (2016-12-21 12:51:09 UTC) #25
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/1414343008/520001
4 years ago (2016-12-22 09:19:14 UTC) #33
commit-bot: I haz the power
Try jobs failed on following builders: presubmit on master.tryserver.webrtc (JOB_FAILED, http://build.chromium.org/p/tryserver.webrtc/builders/presubmit/builds/11694)
4 years ago (2016-12-22 09:32:45 UTC) #35
kjellander_webrtc
+henrika: rubberstamp for deleting chromium/
4 years ago (2016-12-22 09:33:42 UTC) #37
henrika_webrtc
LGTM
4 years ago (2016-12-22 09:35:00 UTC) #38
kjellander_webrtc
4 years ago (2016-12-22 09:40:04 UTC) #40
Message was sent while issue was closed.
Committed patchset #22 (id:520001) manually as
177567c518b121731e507e9b9c4049c4dc96e4c8.

Powered by Google App Engine
This is Rietveld 408576698