Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(170)

Side by Side Diff: PRESUBMIT.py

Issue 1414343008: DEPS: Sync Git subtree mirrors instead of symlinking into chromium/src (Closed) Base URL: https://chromium.googlesource.com/external/webrtc.git@master
Patch Set: Rebased Created 4 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « DEPS ('k') | chromium/.gclient » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 # Copyright (c) 2012 The WebRTC project authors. All Rights Reserved. 1 # Copyright (c) 2012 The WebRTC project authors. All Rights Reserved.
2 # 2 #
3 # Use of this source code is governed by a BSD-style license 3 # Use of this source code is governed by a BSD-style license
4 # that can be found in the LICENSE file in the root of the source 4 # that can be found in the LICENSE file in the root of the source
5 # tree. An additional intellectual property rights grant can be found 5 # tree. An additional intellectual property rights grant can be found
6 # in the file PATENTS. All contributing project authors may 6 # in the file PATENTS. All contributing project authors may
7 # be found in the AUTHORS file in the root of the source tree. 7 # be found in the AUTHORS file in the root of the source tree.
8 8
9 import json 9 import json
10 import os 10 import os
(...skipping 416 matching lines...) Expand 10 before | Expand all | Expand 10 after
427 # they do not follow C++ lint rules. 427 # they do not follow C++ lint rules.
428 black_list = input_api.DEFAULT_BLACK_LIST + ( 428 black_list = input_api.DEFAULT_BLACK_LIST + (
429 r".*\bobjc[\\\/].*", 429 r".*\bobjc[\\\/].*",
430 r".*objc\.[hcm]+$", 430 r".*objc\.[hcm]+$",
431 r"webrtc\/build\/ios\/SDK\/.*", 431 r"webrtc\/build\/ios\/SDK\/.*",
432 ) 432 )
433 source_file_filter = lambda x: input_api.FilterSourceFile(x, None, black_list) 433 source_file_filter = lambda x: input_api.FilterSourceFile(x, None, black_list)
434 results.extend(_CheckApprovedFilesLintClean( 434 results.extend(_CheckApprovedFilesLintClean(
435 input_api, output_api, source_file_filter)) 435 input_api, output_api, source_file_filter))
436 results.extend(input_api.canned_checks.RunPylint(input_api, output_api, 436 results.extend(input_api.canned_checks.RunPylint(input_api, output_api,
437 black_list=(r'^.*gviz_api\.py$', 437 black_list=(r'^base[\\\/].*\.py$',
438 r'^.*gaeunit\.py$',
439 # Embedded shell-script fakes out pylint.
440 r'^build[\\\/].*\.py$', 438 r'^build[\\\/].*\.py$',
441 r'^buildtools[\\\/].*\.py$', 439 r'^buildtools[\\\/].*\.py$',
442 r'^chromium[\\\/].*\.py$',
443 r'^mojo.*[\\\/].*\.py$',
444 r'^out.*[\\\/].*\.py$', 440 r'^out.*[\\\/].*\.py$',
445 r'^testing[\\\/].*\.py$', 441 r'^testing[\\\/].*\.py$',
446 r'^third_party[\\\/].*\.py$', 442 r'^third_party[\\\/].*\.py$',
447 r'^tools[\\\/]clang[\\\/].*\.py$', 443 r'^tools[\\\/].*\.py$',
448 r'^tools[\\\/]generate_library_loader[\\\/].*\.py$',
449 r'^tools[\\\/]generate_stubs[\\\/].*\.py$',
450 r'^tools[\\\/]gn[\\\/].*\.py$',
451 r'^tools[\\\/]isolate_driver.py$',
452 r'^tools[\\\/]mb[\\\/].*\.py$',
453 r'^tools[\\\/]protoc_wrapper[\\\/].*\.py$',
454 r'^tools[\\\/]python[\\\/].*\.py$',
455 r'^tools[\\\/]python_charts[\\\/]data[\\\/].*\.py$',
456 r'^tools[\\\/]refactoring[\\\/].*\.py$',
457 r'^tools[\\\/]swarming_client[\\\/].*\.py$',
458 r'^tools[\\\/]vim[\\\/].*\.py$',
459 r'^tools[\\\/]valgrind[\\\/].*\.py$',
460 r'^tools[\\\/]win[\\\/].*\.py$',
461 # TODO(phoglund): should arguably be checked. 444 # TODO(phoglund): should arguably be checked.
462 r'^tools-webrtc[\\\/]mb[\\\/].*\.py$', 445 r'^tools-webrtc[\\\/]mb[\\\/].*\.py$',
463 r'^tools-webrtc[\\\/]valgrind[\\\/].*\.py$', 446 r'^tools-webrtc[\\\/]valgrind[\\\/].*\.py$',
464 r'^xcodebuild.*[\\\/].*\.py$',), 447 r'^xcodebuild.*[\\\/].*\.py$',),
465 disabled_warnings=['F0401', # Failed to import x 448 disabled_warnings=['F0401', # Failed to import x
466 'E0611', # No package y in x 449 'E0611', # No package y in x
467 'W0232', # Class has no __init__ method 450 'W0232', # Class has no __init__ method
468 ], 451 ],
469 pylintrc='pylintrc')) 452 pylintrc='pylintrc'))
470 453
(...skipping 52 matching lines...) Expand 10 before | Expand all | Expand 10 after
523 input_api, output_api)) 506 input_api, output_api))
524 results.extend(input_api.canned_checks.CheckChangeHasDescription( 507 results.extend(input_api.canned_checks.CheckChangeHasDescription(
525 input_api, output_api)) 508 input_api, output_api))
526 results.extend(_CheckChangeHasBugField(input_api, output_api)) 509 results.extend(_CheckChangeHasBugField(input_api, output_api))
527 results.extend(input_api.canned_checks.CheckChangeHasTestField( 510 results.extend(input_api.canned_checks.CheckChangeHasTestField(
528 input_api, output_api)) 511 input_api, output_api))
529 results.extend(input_api.canned_checks.CheckTreeIsOpen( 512 results.extend(input_api.canned_checks.CheckTreeIsOpen(
530 input_api, output_api, 513 input_api, output_api,
531 json_url='http://webrtc-status.appspot.com/current?format=json')) 514 json_url='http://webrtc-status.appspot.com/current?format=json'))
532 return results 515 return results
OLDNEW
« no previous file with comments | « DEPS ('k') | chromium/.gclient » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698