Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(159)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1414203010: Make ACMCodecDB private to RentACodec (Closed)

Created:
5 years, 1 month ago by kwiberg-webrtc
Modified:
5 years, 1 month ago
Reviewers:
hlundin-webrtc
CC:
webrtc-reviews_webrtc.org, tterriberry_mozilla.com, hlundin-webrtc, peah-webrtc, kwiberg-webrtc, tlegrand-webrtc, the sun
Base URL:
https://chromium.googlesource.com/external/webrtc.git@rac4
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

Make ACMCodecDB private to RentACodec BUG=webrtc:5028 Committed: https://crrev.com/39d8bee39725b6b3da70fab85c6a7e35b7052a06 Cr-Commit-Position: refs/heads/master@{#10549}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -9 lines) Patch
M webrtc/modules/audio_coding/main/acm2/acm_codec_database.h View 2 chunks +1 line, -3 lines 0 comments Download
M webrtc/modules/audio_coding/main/acm2/acm_receiver.h View 1 chunk +0 lines, -1 line 0 comments Download
M webrtc/modules/audio_coding/main/acm2/acm_receiver_unittest_oldapi.cc View 1 chunk +0 lines, -1 line 0 comments Download
M webrtc/modules/audio_coding/main/acm2/audio_coding_module_impl.h View 1 chunk +0 lines, -1 line 0 comments Download
M webrtc/modules/audio_coding/main/acm2/codec_manager.cc View 1 chunk +1 line, -1 line 0 comments Download
M webrtc/modules/audio_coding/main/include/audio_coding_module.h View 1 chunk +0 lines, -1 line 0 comments Download
M webrtc/modules/audio_coding/main/test/opus_test.cc View 1 chunk +0 lines, -1 line 0 comments Download

Depends on Patchset:

Issue 1423043005 Patch 1

Dependent Patchsets:

Issue 1410333015 Patch 60001

Messages

Total messages: 9 (4 generated)
kwiberg-webrtc
5 years, 1 month ago (2015-11-04 14:32:11 UTC) #3
hlundin-webrtc
lgtm
5 years, 1 month ago (2015-11-05 11:59:04 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1414203010/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1414203010/1
5 years, 1 month ago (2015-11-06 23:26:36 UTC) #7
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 1 month ago (2015-11-07 00:22:50 UTC) #8
commit-bot: I haz the power
5 years, 1 month ago (2015-11-07 00:22:57 UTC) #9
Message was sent while issue was closed. 
Patchset 1 (id:??) landed as
https://crrev.com/39d8bee39725b6b3da70fab85c6a7e35b7052a06
Cr-Commit-Position: refs/heads/master@{#10549}

Powered by Google App Engine
This is Rietveld 408576698