Remove ACMCodecDB::Codec, and make the rest of ACMCodecDB private

Remove ACMCodecDB::Codec, and make the rest of ACMCodecDB private

BUG=webrtc:5028
Committed: https://crrev.com/d6c0f8cac19eb549c26f032386e707559313f58f
Cr-Commit-Position: refs/heads/master@{#10546}

[kwiberg-webrtc, 2015-11-04 14:31:17]

Description was changed from

==========
Remove ACMCodecDB::Codec, and make the rest of ACMCodecDB private

BUG=webrtc:5028
==========

to

==========
Remove ACMCodecDB::Codec, and make the rest of ACMCodecDB private

BUG=webrtc:5028
==========

[kwiberg-webrtc, 2015-11-04 14:31:17]

kwiberg@webrtc.org changed reviewers:
+ henrik.lundin@webrtc.org

[hlundin-webrtc, 2015-11-05 11:57:49]

LGTM with question.

https://codereview.webrtc.org/1423043005/diff/1/webrtc/modules/audio_coding/m...
File webrtc/modules/audio_coding/main/acm2/acm_receiver_unittest_oldapi.cc
(right):

https://codereview.webrtc.org/1423043005/diff/1/webrtc/modules/audio_coding/m...
webrtc/modules/audio_coding/main/acm2/acm_receiver_unittest_oldapi.cc:92:
*RentACodec::CodecInstById(*RentACodec::CodecIdFromIndex(codec_id));
What happens if you try to dereference an empty rtc::Maybe?

https://codereview.webrtc.org/1423043005/diff/1/webrtc/modules/audio_coding/m...
File webrtc/modules/audio_coding/main/acm2/codec_manager.cc (right):

https://codereview.webrtc.org/1423043005/diff/1/webrtc/modules/audio_coding/m...
webrtc/modules/audio_coding/main/acm2/codec_manager.cc:56: if
(!RentACodec::IsSupportedNumChannels(*maybe_codec_id, send_codec.channels)
So much nicer... :)

[kwiberg-webrtc, 2015-11-05 12:27:52]

https://codereview.webrtc.org/1423043005/diff/1/webrtc/modules/audio_coding/m...
File webrtc/modules/audio_coding/main/acm2/acm_receiver_unittest_oldapi.cc
(right):

https://codereview.webrtc.org/1423043005/diff/1/webrtc/modules/audio_coding/m...
webrtc/modules/audio_coding/main/acm2/acm_receiver_unittest_oldapi.cc:92:
*RentACodec::CodecInstById(*RentACodec::CodecIdFromIndex(codec_id));
On 2015/11/05 11:57:49, hlundin-webrtc wrote:
> What happens if you try to dereference an empty rtc::Maybe?

DCHECK

Since the old code ignored the possibility of error altogether, I figured this
was good enough.

https://codereview.webrtc.org/1423043005/diff/1/webrtc/modules/audio_coding/m...
File webrtc/modules/audio_coding/main/acm2/codec_manager.cc (right):

https://codereview.webrtc.org/1423043005/diff/1/webrtc/modules/audio_coding/m...
webrtc/modules/audio_coding/main/acm2/codec_manager.cc:56: if
(!RentACodec::IsSupportedNumChannels(*maybe_codec_id, send_codec.channels)
On 2015/11/05 11:57:49, hlundin-webrtc wrote:
> So much nicer... :)

Acknowledged.

[hlundin-webrtc, 2015-11-05 12:30:38]

https://codereview.webrtc.org/1423043005/diff/1/webrtc/modules/audio_coding/m...
File webrtc/modules/audio_coding/main/acm2/acm_receiver_unittest_oldapi.cc
(right):

https://codereview.webrtc.org/1423043005/diff/1/webrtc/modules/audio_coding/m...
webrtc/modules/audio_coding/main/acm2/acm_receiver_unittest_oldapi.cc:92:
*RentACodec::CodecInstById(*RentACodec::CodecIdFromIndex(codec_id));
On 2015/11/05 12:27:52, kwiberg-webrtc wrote:
> On 2015/11/05 11:57:49, hlundin-webrtc wrote:
> > What happens if you try to dereference an empty rtc::Maybe?
> 
> DCHECK
> 
> Since the old code ignored the possibility of error altogether, I figured this
> was good enough.

Fair enough.

[kwiberg-webrtc, 2015-11-06 20:58:29]

The CQ bit was checked by kwiberg@webrtc.org

[kwiberg-webrtc, 2015-11-06 20:58:29]

The patchset sent to the CQ was uploaded after l-g-t-m from
henrik.lundin@webrtc.org
Link to the patchset: https://codereview.webrtc.org/1423043005/#ps20001 (title:
"rebase")

[commit-bot: I haz the power, 2015-11-06 20:58:37]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1423043005/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1423043005/20001

[commit-bot: I haz the power, 2015-11-06 22:28:05]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2015-11-06 22:28:14]

Patchset 2 (id:??) landed as
https://crrev.com/d6c0f8cac19eb549c26f032386e707559313f58f
Cr-Commit-Position: refs/heads/master@{#10546}