Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(185)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1410333015: Let Rent-A-Codec™ create and own speech encoders (Closed)

Created:
5 years, 1 month ago by kwiberg-webrtc
Modified:
5 years, 1 month ago
Reviewers:
hlundin-webrtc
CC:
webrtc-reviews_webrtc.org, tterriberry_mozilla.com, hlundin-webrtc, peah-webrtc, kwiberg-webrtc, tlegrand-webrtc, the sun
Base URL:
https://chromium.googlesource.com/external/webrtc.git@rac5
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

Let Rent-A-Codec™ create and own speech encoders BUG=webrtc:5028 Committed: https://crrev.com/805fc710f7fb1b399bcfae70c8b484a77b49267f Cr-Commit-Position: refs/heads/master@{#10575}

Patch Set 1 : #

Total comments: 2

Patch Set 2 : comment fix #

Unified diffs Side-by-side diffs Delta from patch set Stats (+137 lines, -115 lines) Patch
M webrtc/modules/audio_coding/main/acm2/codec_owner.h View 2 chunks +4 lines, -22 lines 0 comments Download
M webrtc/modules/audio_coding/main/acm2/codec_owner.cc View 5 chunks +11 lines, -93 lines 0 comments Download
M webrtc/modules/audio_coding/main/acm2/rent_a_codec.h View 1 2 chunks +33 lines, -0 lines 0 comments Download
M webrtc/modules/audio_coding/main/acm2/rent_a_codec.cc View 2 chunks +89 lines, -0 lines 0 comments Download

Messages

Total messages: 15 (9 generated)
kwiberg-webrtc
https://codereview.webrtc.org/1410333015/diff/60001/webrtc/modules/audio_coding/main/acm2/rent_a_codec.h File webrtc/modules/audio_coding/main/acm2/rent_a_codec.h (right): https://codereview.webrtc.org/1410333015/diff/60001/webrtc/modules/audio_coding/main/acm2/rent_a_codec.h#newcode185 webrtc/modules/audio_coding/main/acm2/rent_a_codec.h:185: // Creates and returns an audio decoder built to ...
5 years, 1 month ago (2015-11-06 22:18:40 UTC) #4
kwiberg-webrtc
Please have a look. The diff seems larger than it is because I've moved some ...
5 years, 1 month ago (2015-11-06 22:21:04 UTC) #7
hlundin-webrtc
lgtm https://codereview.webrtc.org/1410333015/diff/60001/webrtc/modules/audio_coding/main/acm2/rent_a_codec.h File webrtc/modules/audio_coding/main/acm2/rent_a_codec.h (right): https://codereview.webrtc.org/1410333015/diff/60001/webrtc/modules/audio_coding/main/acm2/rent_a_codec.h#newcode185 webrtc/modules/audio_coding/main/acm2/rent_a_codec.h:185: // Creates and returns an audio decoder built ...
5 years, 1 month ago (2015-11-10 10:27:59 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1410333015/80001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1410333015/80001
5 years, 1 month ago (2015-11-10 10:33:23 UTC) #13
commit-bot: I haz the power
Committed patchset #2 (id:80001)
5 years, 1 month ago (2015-11-10 12:05:20 UTC) #14
commit-bot: I haz the power
5 years, 1 month ago (2015-11-10 12:05:29 UTC) #15
Message was sent while issue was closed. 
Patchset 2 (id:??) landed as
https://crrev.com/805fc710f7fb1b399bcfae70c8b484a77b49267f
Cr-Commit-Position: refs/heads/master@{#10575}

Powered by Google App Engine
This is Rietveld 408576698