Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(137)

Unified Diff: webrtc/voice_engine/include/voe_audio_processing.h

Issue 1413483003: Added option to specify a maximum file size when recording an AEC dump. (Closed) Base URL: https://chromium.googlesource.com/external/webrtc.git@master
Patch Set: Initial version Created 5 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: webrtc/voice_engine/include/voe_audio_processing.h
diff --git a/webrtc/voice_engine/include/voe_audio_processing.h b/webrtc/voice_engine/include/voe_audio_processing.h
index fd70f957752ee1114111ac494c39ad4c2c7813a4..0c85f374d242d8dd3e3f505cdd541ce2ce384a40 100644
--- a/webrtc/voice_engine/include/voe_audio_processing.h
+++ b/webrtc/voice_engine/include/voe_audio_processing.h
@@ -190,10 +190,17 @@ class WEBRTC_DLLEXPORT VoEAudioProcessing {
// The file can later be used for off-line analysis of the AP performance.
virtual int StartDebugRecording(const char* fileNameUTF8) = 0;
+ // Same as above but with a specified maximum file size in bytes.
+ virtual int StartDebugRecording(const char* fileNameUTF8,
Andrew MacDonald 2015/10/23 17:15:18 The preferred method now is to access the AudioPro
the sun 2015/10/26 10:37:20 Thanks Andrew; indeed we don't want to and don't h
ivoc 2015/11/05 13:14:46 I removed this function, should I remove the Start
+ int max_size_bytes) = 0;
+
// Same as above but sets and uses an existing file handle. Takes ownership
// of |file_handle| and passes it on to the audio processing module.
virtual int StartDebugRecording(FILE* file_handle) = 0;
+ // Same as above but with a specified maximum file size in bytes.
+ virtual int StartDebugRecording(FILE* file_handle, int max_size_bytes) = 0;
+
// Disables recording of AP debugging information.
virtual int StopDebugRecording() = 0;

Powered by Google App Engine
This is Rietveld 408576698