Added option to specify a maximum file size when recording an AEC dump.

webrtc/voice_engine/voe_audio_processing_impl.cc

Index: webrtc/voice_engine/voe_audio_processing_impl.cc
diff --git a/webrtc/voice_engine/voe_audio_processing_impl.cc b/webrtc/voice_engine/voe_audio_processing_impl.cc
index bbc3f0d3caf8db5a88b9c2f18db05dbae88725c2..8b300f795b641a5aa5e355e287c86fd037c53b72 100644
--- a/webrtc/voice_engine/voe_audio_processing_impl.cc
+++ b/webrtc/voice_engine/voe_audio_processing_impl.cc
@@ -930,6 +930,19 @@ int VoEAudioProcessingImpl::StartDebugRecording(const char* fileNameUTF8) {
   return _shared->audio_processing()->StartDebugRecording(fileNameUTF8);
 }
 
+int VoEAudioProcessingImpl::StartDebugRecording(const char* fileNameUTF8,
+                                                int max_size_bytes) {
+  WEBRTC_TRACE(kTraceApiCall, kTraceVoice, VoEId(_shared->instance_id(), -1),
+               "StartDebugRecording()");
+  if (!_shared->statistics().Initialized()) {
+    _shared->SetLastError(VE_NOT_INITED, kTraceError);
+    return -1;
+  }
+
+  return _shared->audio_processing()->StartDebugRecording(fileNameUTF8,
+                                                          max_size_bytes);
+}

[kwiberg-webrtc, 2015/10/25 02:29:12]

Duplicates code from the preceding function. Can you make one of them call the
other?

[ivoc, 2015/11/05 13:14:46]

This code has been removed in the new version.

+
 int VoEAudioProcessingImpl::StartDebugRecording(FILE* file_handle) {
   WEBRTC_TRACE(kTraceApiCall, kTraceVoice, VoEId(_shared->instance_id(), -1),
                "StartDebugRecording()");
@@ -941,6 +954,19 @@ int VoEAudioProcessingImpl::StartDebugRecording(FILE* file_handle) {
   return _shared->audio_processing()->StartDebugRecording(file_handle);
 }
 
+int VoEAudioProcessingImpl::StartDebugRecording(FILE* file_handle,
+                                                int max_size_bytes) {
+  WEBRTC_TRACE(kTraceApiCall, kTraceVoice, VoEId(_shared->instance_id(), -1),
+               "StartDebugRecording()");
+  if (!_shared->statistics().Initialized()) {
+    _shared->SetLastError(VE_NOT_INITED, kTraceError);
+    return -1;
+  }
+
+  return _shared->audio_processing()->StartDebugRecording(file_handle,
+                                                          max_size_bytes);
+}

[kwiberg-webrtc, 2015/10/25 02:29:12]

Code dup; one call the other?

[ivoc, 2015/11/05 13:14:46]

This code has been removed in the new version.

+
 int VoEAudioProcessingImpl::StopDebugRecording() {
   WEBRTC_TRACE(kTraceApiCall, kTraceVoice, VoEId(_shared->instance_id(), -1),
                "StopDebugRecording()");