Added option to specify a maximum file size when recording an AEC dump.

webrtc/voice_engine/voe_audio_processing_impl.cc

 /*
  *  Copyright (c) 2012 The WebRTC project authors. All Rights Reserved.
  *
  *  Use of this source code is governed by a BSD-style license
  *  that can be found in the LICENSE file in the root of the source
  *  tree. An additional intellectual property rights grant can be found
  *  in the file PATENTS.  All contributing project authors may
  *  be found in the AUTHORS file in the root of the source tree.
  */
 
@@ skipping 912 matching lines @@
   WEBRTC_TRACE(kTraceApiCall, kTraceVoice, VoEId(_shared->instance_id(), -1),
                "StartDebugRecording()");
   if (!_shared->statistics().Initialized()) {
     _shared->SetLastError(VE_NOT_INITED, kTraceError);
     return -1;
   }
 
   return _shared->audio_processing()->StartDebugRecording(fileNameUTF8);
 }
 
+int VoEAudioProcessingImpl::StartDebugRecording(const char* fileNameUTF8,
+                                                int max_size_bytes) {
+  WEBRTC_TRACE(kTraceApiCall, kTraceVoice, VoEId(_shared->instance_id(), -1),
+               "StartDebugRecording()");
+  if (!_shared->statistics().Initialized()) {
+    _shared->SetLastError(VE_NOT_INITED, kTraceError);
+    return -1;
+  }
+
+  return _shared->audio_processing()->StartDebugRecording(fileNameUTF8,
+                                                          max_size_bytes);
+}

[kwiberg-webrtc, 2015/10/25 02:29:12]

Duplicates code from the preceding function. Can you make one of them call the
other?

[ivoc, 2015/11/05 13:14:46]

This code has been removed in the new version.

+
 int VoEAudioProcessingImpl::StartDebugRecording(FILE* file_handle) {
   WEBRTC_TRACE(kTraceApiCall, kTraceVoice, VoEId(_shared->instance_id(), -1),
                "StartDebugRecording()");
   if (!_shared->statistics().Initialized()) {
     _shared->SetLastError(VE_NOT_INITED, kTraceError);
     return -1;
   }
 
   return _shared->audio_processing()->StartDebugRecording(file_handle);
 }
 
+int VoEAudioProcessingImpl::StartDebugRecording(FILE* file_handle,
+                                                int max_size_bytes) {
+  WEBRTC_TRACE(kTraceApiCall, kTraceVoice, VoEId(_shared->instance_id(), -1),
+               "StartDebugRecording()");
+  if (!_shared->statistics().Initialized()) {
+    _shared->SetLastError(VE_NOT_INITED, kTraceError);
+    return -1;
+  }
+
+  return _shared->audio_processing()->StartDebugRecording(file_handle,
+                                                          max_size_bytes);
+}

[kwiberg-webrtc, 2015/10/25 02:29:12]

Code dup; one call the other?

[ivoc, 2015/11/05 13:14:46]

This code has been removed in the new version.

+
 int VoEAudioProcessingImpl::StopDebugRecording() {
   WEBRTC_TRACE(kTraceApiCall, kTraceVoice, VoEId(_shared->instance_id(), -1),
                "StopDebugRecording()");
   if (!_shared->statistics().Initialized()) {
     _shared->SetLastError(VE_NOT_INITED, kTraceError);
     return -1;
   }
 
   return _shared->audio_processing()->StopDebugRecording();
 }
@@ skipping 89 matching lines @@
 }
 
 bool VoEAudioProcessingImpl::IsStereoChannelSwappingEnabled() {
   LOG_API0();
   return _shared->transmit_mixer()->IsStereoChannelSwappingEnabled();
 }
 
 #endif  // #ifdef WEBRTC_VOICE_ENGINE_AUDIO_PROCESSING_API
 
 }  // namespace webrtc