Added option to specify a maximum file size when recording an AEC dump.

webrtc/voice_engine/include/voe_audio_processing.h

 /*
  *  Copyright (c) 2012 The WebRTC project authors. All Rights Reserved.
  *
  *  Use of this source code is governed by a BSD-style license
  *  that can be found in the LICENSE file in the root of the source
  *  tree. An additional intellectual property rights grant can be found
  *  in the file PATENTS.  All contributing project authors may
  *  be found in the AUTHORS file in the root of the source tree.
  */
 
@@ skipping 172 matching lines @@
   // delay values that potentially can break the EC. The values are aggregated
   // over one second and the last updated metrics are returned.
   virtual int GetEcDelayMetrics(int& delay_median,
                                 int& delay_std,
                                 float& fraction_poor_delays) = 0;
 
   // Enables recording of Audio Processing (AP) debugging information.
   // The file can later be used for off-line analysis of the AP performance.
   virtual int StartDebugRecording(const char* fileNameUTF8) = 0;
 
+  // Same as above but with a specified maximum file size in bytes.
+  virtual int StartDebugRecording(const char* fileNameUTF8,

[Andrew MacDonald, 2015/10/23 17:15:18]

The preferred method now is to access the AudioProcessing instance directly in
libjingle, through:
voe_wrapper_->base()->audio_processing()

This wrapper layer should go away entirely with solenberg's refactoring; it
would be nicer to avoid adding new APIs, but I leave it up to you guys.

[the sun, 2015/10/26 10:37:20]

Thanks Andrew; indeed we don't want to and don't have to add the extra
interfaces here since we can get to the APM directly.

[ivoc, 2015/11/05 13:14:46]

I removed this function, should I remove the StartDebugRecording() function that
was already here as well?

+                                  int max_size_bytes) = 0;
+
   // Same as above but sets and uses an existing file handle. Takes ownership
   // of |file_handle| and passes it on to the audio processing module.
   virtual int StartDebugRecording(FILE* file_handle) = 0;
 
+  // Same as above but with a specified maximum file size in bytes.
+  virtual int StartDebugRecording(FILE* file_handle, int max_size_bytes) = 0;
+
   // Disables recording of AP debugging information.
   virtual int StopDebugRecording() = 0;
 
   // Enables or disables detection of disturbing keyboard typing.
   // An error notification will be given as a callback upon detection.
   virtual int SetTypingDetectionStatus(bool enable) = 0;
 
   // Gets the current typing detection status.
   virtual int GetTypingDetectionStatus(bool& enabled) = 0;
 
@@ skipping 24 matching lines @@
   virtual bool IsStereoChannelSwappingEnabled() = 0;
 
  protected:
   VoEAudioProcessing() {}
   virtual ~VoEAudioProcessing() {}
 };
 
 }  // namespace webrtc
 
 #endif  // WEBRTC_VOICE_ENGINE_VOE_AUDIO_PROCESSING_H