Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(871)

Issue 1411823003: Revert of Add aecdump support to audioproc_f. (Closed)

Created:
5 years, 1 month ago by kjellander (google.com)
Modified:
5 years, 1 month ago
CC:
webrtc-reviews_webrtc.org, peah-webrtc, tterriberry_mozilla.com, hlundin-webrtc, kwiberg-webrtc, the sun, aluebs-webrtc, bjornv1
Base URL:
https://chromium.googlesource.com/external/webrtc.git@master
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

Revert of Add aecdump support to audioproc_f. (patchset #8 id:200001 of https://codereview.webrtc.org/1409943002/ ) Reason for revert: This breaks iOS GYP generation as described on http://www.webrtc.org/native-code/ios I'm going to drive getting the build_with_libjingle=1 setting removed from the bots to match the official instructions. See https://code.google.com/p/webrtc/issues/detail?id=4653 for more context, as this is exactly what that issue tries to solve. Original issue's description: > Add aecdump support to audioproc_f. > > Add a new interface to abstract away file operations. This CL temporarily > removes support for dumping the output of reverse streams. It will be easy to > restore in the new framework, although we may decide to only allow it with > the aecdump format. > > We also now require the user to specify the output format, rather than > defaulting to the input format. > > TEST=Bit-exact output to the previous audioproc_f version using an input wav > file, and to the legacy audioproc using an aecdump file. > > Committed: https://crrev.com/bdafe31b86e9819b0adb9041f87e6194b7422b08 > Cr-Commit-Position: refs/heads/master@{#10460} TBR=aluebs@webrtc.org,peah@webrtc.org,andrew@webrtc.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+166 lines, -470 lines) Patch
M webrtc/common_audio/wav_file.h View 1 chunk +0 lines, -3 lines 0 comments Download
M webrtc/common_audio/wav_file.cc View 2 chunks +2 lines, -10 lines 0 comments Download
M webrtc/modules/audio_processing/audio_processing_tests.gypi View 1 chunk +0 lines, -3 lines 0 comments Download
D webrtc/modules/audio_processing/test/audio_file_processor.h View 1 chunk +0 lines, -139 lines 0 comments Download
D webrtc/modules/audio_processing/test/audio_file_processor.cc View 1 chunk +0 lines, -177 lines 0 comments Download
M webrtc/modules/audio_processing/test/audioproc_float.cc View 4 chunks +151 lines, -61 lines 0 comments Download
M webrtc/modules/audio_processing/test/process_test.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M webrtc/modules/audio_processing/test/test_utils.h View 2 chunks +0 lines, -32 lines 0 comments Download
M webrtc/modules/audio_processing/test/test_utils.cc View 2 chunks +9 lines, -42 lines 0 comments Download
M webrtc/system_wrappers/include/tick_util.h View 2 chunks +2 lines, -1 line 0 comments Download

Messages

Total messages: 5 (1 generated)
kjellander (google.com)
Created Revert of Add aecdump support to audioproc_f.
5 years, 1 month ago (2015-11-05 13:58:36 UTC) #1
kjellander_webrtc
On 2015/11/05 13:58:36, kjellander (google.com) wrote: > Created Revert of Add aecdump support to audioproc_f. ...
5 years, 1 month ago (2015-11-05 14:02:36 UTC) #2
kjellander_webrtc
On 2015/11/05 14:02:36, kjellander (webrtc) wrote: > On 2015/11/05 13:58:36, kjellander (http://google.com) wrote: > > ...
5 years, 1 month ago (2015-11-05 14:06:30 UTC) #3
kjellander_webrtc
5 years, 1 month ago (2015-11-05 14:07:13 UTC) #4
On 2015/11/05 14:06:30, kjellander (webrtc) wrote:
> On 2015/11/05 14:02:36, kjellander (webrtc) wrote:
> > On 2015/11/05 13:58:36, kjellander (http://google.com) wrote:
> > > Created Revert of Add aecdump support to audioproc_f.
> > 
> > Made the revert with my http://google.com account :( lgtm'ing with
> http://webrtc.org to get
> > this in (will need a rebase to apply)
> 
> Nevermind this CL, I cannot upload a new patch set using my http://webrtc.org
account.
> I'll close this and create a new revert CL with the right account, doh!

New revert CL: https://codereview.webrtc.org/1423693008/

Powered by Google App Engine
This is Rietveld 408576698