Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1294)

Issue 1406123011: Let AudioCodingModule::SendCodec return Maybe<CodecInst> (Closed)

Created:
5 years, 1 month ago by kwiberg-webrtc
Modified:
5 years, 1 month ago
Reviewers:
the sun, hlundin-webrtc
CC:
webrtc-reviews_webrtc.org, kwiberg-webrtc, henrika_webrtc, tlegrand-webrtc, tterriberry_mozilla.com, hlundin-webrtc, peah-webrtc, the sun
Base URL:
https://chromium.googlesource.com/external/webrtc.git@master
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

Let AudioCodingModule::SendCodec return Maybe<CodecInst> And deal with the consequences thereof... Committed: https://crrev.com/1fd4a4ab35f1fcb08b551befca180de9a1f55dfc Cr-Commit-Position: refs/heads/master@{#10497}

Patch Set 1 #

Total comments: 4

Patch Set 2 : review fix #

Unified diffs Side-by-side diffs Delta from patch set Stats (+72 lines, -78 lines) Patch
M webrtc/modules/audio_coding/main/acm2/acm_receiver_unittest_oldapi.cc View 1 chunk +3 lines, -3 lines 0 comments Download
M webrtc/modules/audio_coding/main/acm2/audio_coding_module_impl.h View 1 chunk +1 line, -1 line 0 comments Download
M webrtc/modules/audio_coding/main/acm2/audio_coding_module_impl.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M webrtc/modules/audio_coding/main/acm2/codec_manager.h View 2 chunks +2 lines, -1 line 0 comments Download
M webrtc/modules/audio_coding/main/acm2/codec_manager.cc View 2 chunks +3 lines, -4 lines 0 comments Download
M webrtc/modules/audio_coding/main/include/audio_coding_module.h View 2 chunks +3 lines, -6 lines 0 comments Download
M webrtc/modules/audio_coding/main/test/APITest.cc View 7 chunks +25 lines, -28 lines 0 comments Download
M webrtc/modules/audio_coding/main/test/EncodeDecodeTest.cc View 1 chunk +1 line, -2 lines 0 comments Download
M webrtc/modules/audio_coding/main/test/PacketLossTest.cc View 1 chunk +1 line, -2 lines 0 comments Download
M webrtc/modules/audio_coding/main/test/TestAllCodecs.cc View 1 chunk +1 line, -2 lines 0 comments Download
M webrtc/modules/audio_coding/main/test/TestStereo.cc View 1 chunk +6 lines, -5 lines 0 comments Download
M webrtc/modules/audio_coding/main/test/TestVADDTX.cc View 1 chunk +3 lines, -3 lines 0 comments Download
M webrtc/modules/audio_coding/main/test/TwoWayCommunication.cc View 2 chunks +5 lines, -7 lines 0 comments Download
M webrtc/modules/audio_coding/main/test/iSACTest.cc View 3 chunks +10 lines, -11 lines 0 comments Download
M webrtc/voice_engine/channel.cc View 1 1 chunk +6 lines, -1 line 0 comments Download

Messages

Total messages: 13 (4 generated)
kwiberg-webrtc
Please have a look. I've tried to divide the load evenly between you. Henrik: audio_coding ...
5 years, 1 month ago (2015-11-03 08:15:28 UTC) #3
hlundin-webrtc
Nice! audio_coding: lgtm
5 years, 1 month ago (2015-11-03 08:56:13 UTC) #4
the sun
lgtm, save for one nit https://codereview.webrtc.org/1406123011/diff/1/webrtc/voice_engine/channel.cc File webrtc/voice_engine/channel.cc (right): https://codereview.webrtc.org/1406123011/diff/1/webrtc/voice_engine/channel.cc#newcode1247 webrtc/voice_engine/channel.cc:1247: codec = *send_codec; nit: ...
5 years, 1 month ago (2015-11-03 10:13:42 UTC) #5
kwiberg-webrtc
https://codereview.webrtc.org/1406123011/diff/1/webrtc/voice_engine/channel.cc File webrtc/voice_engine/channel.cc (right): https://codereview.webrtc.org/1406123011/diff/1/webrtc/voice_engine/channel.cc#newcode1247 webrtc/voice_engine/channel.cc:1247: codec = *send_codec; On 2015/11/03 10:13:42, the sun wrote: ...
5 years, 1 month ago (2015-11-03 12:23:53 UTC) #6
the sun
https://codereview.webrtc.org/1406123011/diff/1/webrtc/voice_engine/channel.cc File webrtc/voice_engine/channel.cc (right): https://codereview.webrtc.org/1406123011/diff/1/webrtc/voice_engine/channel.cc#newcode1247 webrtc/voice_engine/channel.cc:1247: codec = *send_codec; On 2015/11/03 12:23:53, kwiberg-webrtc wrote: > ...
5 years, 1 month ago (2015-11-03 12:38:21 UTC) #7
kwiberg-webrtc
https://codereview.webrtc.org/1406123011/diff/1/webrtc/voice_engine/channel.cc File webrtc/voice_engine/channel.cc (right): https://codereview.webrtc.org/1406123011/diff/1/webrtc/voice_engine/channel.cc#newcode1247 webrtc/voice_engine/channel.cc:1247: codec = *send_codec; On 2015/11/03 12:38:21, the sun wrote: ...
5 years, 1 month ago (2015-11-03 13:08:19 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1406123011/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1406123011/20001
5 years, 1 month ago (2015-11-03 19:19:29 UTC) #11
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 1 month ago (2015-11-03 19:20:54 UTC) #12
commit-bot: I haz the power
5 years, 1 month ago (2015-11-03 19:21:13 UTC) #13
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/1fd4a4ab35f1fcb08b551befca180de9a1f55dfc
Cr-Commit-Position: refs/heads/master@{#10497}

Powered by Google App Engine
This is Rietveld 408576698