webrtc/modules/audio_coding/main/test/PacketLossTest.cc - Issue 1406123011: Let AudioCodingModule::SendCodec return Maybe<CodecInst>

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: webrtc/modules/audio_coding/main/test/PacketLossTest.cc

Issue 1406123011: Let AudioCodingModule::SendCodec return Maybe<CodecInst> (Closed) Base URL: https://chromium.googlesource.com/external/webrtc.git@master

Patch Set: review fix Created 5 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « webrtc/modules/audio_coding/main/test/EncodeDecodeTest.cc ('k') | webrtc/modules/audio_coding/main/test/TestAllCodecs.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: webrtc/modules/audio_coding/main/test/PacketLossTest.cc

diff --git a/webrtc/modules/audio_coding/main/test/PacketLossTest.cc b/webrtc/modules/audio_coding/main/test/PacketLossTest.cc

index f19d491d2dadde4bd5f5ea90c9156d053f1bb196..f7c96faacd691e994e2768f1eb5c0a6cee501583 100644

--- a/webrtc/modules/audio_coding/main/test/PacketLossTest.cc

+++ b/webrtc/modules/audio_coding/main/test/PacketLossTest.cc

@@ -143,8 +143,7 @@ void PacketLossTest::Perform() {

sender_->Setup(acm.get(), &rtpFile, in_file_name_, sample_rate_hz_, channels_,

expected_loss_rate_);

- struct CodecInst sendCodecInst;

- if (acm->SendCodec(&sendCodecInst) >= 0) {

+ if (acm->SendCodec()) {

sender_->Run();

}

sender_->Teardown();