Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(453)

Unified Diff: webrtc/modules/audio_coding/main/include/audio_coding_module.h

Issue 1406123011: Let AudioCodingModule::SendCodec return Maybe<CodecInst> (Closed) Base URL: https://chromium.googlesource.com/external/webrtc.git@master
Patch Set: review fix Created 5 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: webrtc/modules/audio_coding/main/include/audio_coding_module.h
diff --git a/webrtc/modules/audio_coding/main/include/audio_coding_module.h b/webrtc/modules/audio_coding/main/include/audio_coding_module.h
index 2b23eb06eb2de30cd6249600f7ebc72ba035ca2e..869cd824bea62378b75c580d79b66065fc744e18 100644
--- a/webrtc/modules/audio_coding/main/include/audio_coding_module.h
+++ b/webrtc/modules/audio_coding/main/include/audio_coding_module.h
@@ -13,6 +13,7 @@
#include <vector>
+#include "webrtc/base/maybe.h"
#include "webrtc/common_types.h"
#include "webrtc/modules/audio_coding/main/acm2/acm_codec_database.h"
#include "webrtc/modules/audio_coding/main/include/audio_coding_module_typedefs.h"
@@ -206,14 +207,10 @@ class AudioCodingModule {
// int32_t SendCodec()
// Get parameters for the codec currently registered as send codec.
//
- // Output:
- // -current_send_codec : parameters of the send codec.
- //
// Return value:
- // -1 if failed to get send codec,
- // 0 if succeeded.
+ // The send codec, or nothing if we don't have one
//
- virtual int32_t SendCodec(CodecInst* current_send_codec) const = 0;
+ virtual rtc::Maybe<CodecInst> SendCodec() const = 0;
///////////////////////////////////////////////////////////////////////////
// int32_t SendFrequency()
« no previous file with comments | « webrtc/modules/audio_coding/main/acm2/codec_manager.cc ('k') | webrtc/modules/audio_coding/main/test/APITest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698