Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1119)

Unified Diff: webrtc/audio_state.h

Issue 1403363003: Move VoiceEngineObserver into AudioSendStream so that we detect typing noises and return properly i… (Closed) Base URL: https://chromium.googlesource.com/external/webrtc.git@master
Patch Set: better comments Created 5 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: webrtc/audio_state.h
diff --git a/webrtc/audio_state.h b/webrtc/audio_state.h
new file mode 100644
index 0000000000000000000000000000000000000000..176304401e242d581ea7adca7630fb668099749b
--- /dev/null
+++ b/webrtc/audio_state.h
@@ -0,0 +1,36 @@
+/*
+ * Copyright (c) 2015 The WebRTC project authors. All Rights Reserved.
+ *
+ * Use of this source code is governed by a BSD-style license
+ * that can be found in the LICENSE file in the root of the source
+ * tree. An additional intellectual property rights grant can be found
+ * in the file PATENTS. All contributing project authors may
+ * be found in the AUTHORS file in the root of the source tree.
+ */
+#ifndef WEBRTC_AUDIO_STATE_H_
+#define WEBRTC_AUDIO_STATE_H_
+
+namespace webrtc {
+
+class AudioDeviceModule;
+class VoiceEngine;
+
+// AudioState holds the state which must be shared between multiple instances of
+// webrtc::Call for audio processing purposes.
+class AudioState {
+ public:
+ struct Config {
+ // VoiceEngine used for audio streams and audio/video synchronization.
tommi 2015/10/29 16:28:50 what about ownership/lifetime? (same for voice_eng
the sun 2015/10/30 12:19:01 Made it clear in the comment, or did you have anyt
tommi 2015/11/02 13:46:53 Thanks, comment is what I meant.
the sun 2015/11/03 12:41:07 Acknowledged.
+ VoiceEngine* voice_engine = nullptr;
+
+ // The AudioDeviceModule associated with the Calls.
+ AudioDeviceModule* audio_device_module = nullptr;
+ };
+
+ static AudioState* Create(const AudioState::Config& config);
+
+ virtual ~AudioState() {}
+};
+} // namespace webrtc
+
+#endif // WEBRTC_AUDIO_STATE_H_

Powered by Google App Engine
This is Rietveld 408576698