Move VoiceEngineObserver into AudioSendStream so that we detect typing noises and return properly i…

webrtc/call.h

Index: webrtc/call.h
diff --git a/webrtc/call.h b/webrtc/call.h
index e6e8cdee0bd35461e71c40dfbe9a780ba2ccb8d4..18c835f36e65854e95b616141a8f896981a8da65 100644
--- a/webrtc/call.h
+++ b/webrtc/call.h
@@ -16,16 +16,14 @@
 #include "webrtc/common_types.h"
 #include "webrtc/audio_receive_stream.h"
 #include "webrtc/audio_send_stream.h"
+#include "webrtc/audio_state.h"
 #include "webrtc/base/socket.h"
 #include "webrtc/video_receive_stream.h"
 #include "webrtc/video_send_stream.h"
 
 namespace webrtc {
 
-class AudioDeviceModule;
 class AudioProcessing;
-class VoiceEngine;
-class VoiceEngineObserver;
 
 const char* Version();
 
@@ -74,9 +72,6 @@ class Call {
   struct Config {
     static const int kDefaultStartBitrateBps;
 
-    // VoiceEngine used for audio/video synchronization for this Call.
-    VoiceEngine* voice_engine = nullptr;
-
     // Bitrate config used until valid bitrate estimates are calculated. Also
     // used to cap total bitrate used.
     struct BitrateConfig {
@@ -85,11 +80,14 @@ class Call {
       int max_bitrate_bps = -1;
     } bitrate_config;
 
-    struct AudioConfig {
-      AudioDeviceModule* audio_device_module = nullptr;
-      AudioProcessing* audio_processing = nullptr;
-      VoiceEngineObserver* voice_engine_observer = nullptr;
-    } audio_config;
+    // AudioState which is possibly shared between multiple calls. Must exist
+    // for the lifetime of this Call.
+    // TODO(solenberg): Change this to a shared_ptr once we can use C++11.

[tommi, 2015/10/29 16:28:50]

what about using scoped_refptr in the meantime?  As is it feels unsafe.  Another
alternative is linked_ptr.

[the sun, 2015/10/30 12:19:01]

Ah, nice, linked_ptr fits the bill (what I like about std::shared_ptr is that
the ref count is external to the object, with no forced inheriting from a base
class and such).

[tommi, 2015/11/02 13:46:53]

Yes, I think we'll replace use of linked_ptr with shared_ptr as soon as the
latter becomes available to us.

[the sun, 2015/11/03 12:41:07]

Acknowledged.

+    AudioState* audio_state = nullptr;
+
+    // Audio Processing Module to be used in this call.
+    // TODO(solenberg): Change this to a shared_ptr once we can use C++11.
+    AudioProcessing* audio_processing = nullptr;
   };
 
   struct Stats {