Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(499)

Issue 1398823003: Remove MediaChannel::SetRemoteRenderer(). (Closed)

Created:
5 years, 2 months ago by the sun
Modified:
5 years, 2 months ago
Reviewers:
tommi
CC:
webrtc-reviews_webrtc.org, interface-changes_webrtc.org, rwolff_gocast.it, yujie_mao (webrtc), Andrew MacDonald, tterriberry_mozilla.com, qiang.lu, niklas.enbom, peah-webrtc, kwiberg-webrtc
Base URL:
https://chromium.googlesource.com/external/webrtc.git@master
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

Remove MediaChannel::SetRemoteRenderer(). This is following discussion in: https://codereview.webrtc.org/1385893002/diff/60001/talk/media/webrtc/webrtcvoiceengine.cc#newcode2410 BUG=webrtc:4690 Committed: https://crrev.com/d4cec0d8fa7913bc9dfa9137e44cca9098e16698 Cr-Commit-Position: refs/heads/master@{#10237}

Patch Set 1 #

Patch Set 2 : Remove AudioRenderer argument from SetAudioPlayout() #

Patch Set 3 : rebase #

Patch Set 4 : rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+15 lines, -79 lines) Patch
M talk/app/webrtc/mediastreamprovider.h View 1 1 chunk +1 line, -3 lines 0 comments Download
M talk/app/webrtc/rtpreceiver.cc View 1 2 chunks +2 lines, -2 lines 0 comments Download
M talk/app/webrtc/rtpsenderreceiver_unittest.cc View 1 5 chunks +8 lines, -9 lines 0 comments Download
M talk/app/webrtc/webrtcsession.h View 1 1 chunk +1 line, -3 lines 0 comments Download
M talk/app/webrtc/webrtcsession.cc View 1 2 1 chunk +1 line, -8 lines 0 comments Download
M talk/app/webrtc/webrtcsession_unittest.cc View 1 2 1 chunk +2 lines, -3 lines 0 comments Download
M talk/media/base/fakemediaengine.h View 1 2 2 chunks +0 lines, -19 lines 0 comments Download
M talk/media/base/mediachannel.h View 1 2 1 chunk +0 lines, -2 lines 0 comments Download
M talk/media/webrtc/webrtcvoiceengine.h View 1 2 1 chunk +0 lines, -1 line 0 comments Download
M talk/media/webrtc/webrtcvoiceengine.cc View 1 2 1 chunk +0 lines, -23 lines 0 comments Download
M talk/session/media/channel.h View 1 2 1 chunk +0 lines, -1 line 0 comments Download
M talk/session/media/channel.cc View 1 2 1 chunk +0 lines, -5 lines 0 comments Download

Messages

Total messages: 13 (7 generated)
the sun
5 years, 2 months ago (2015-10-09 08:26:51 UTC) #2
the sun
5 years, 2 months ago (2015-10-09 14:25:33 UTC) #5
tommi
lgtm
5 years, 2 months ago (2015-10-09 14:33:46 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1398823003/60001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1398823003/60001
5 years, 2 months ago (2015-10-09 14:47:03 UTC) #11
commit-bot: I haz the power
Committed patchset #4 (id:60001)
5 years, 2 months ago (2015-10-09 15:55:52 UTC) #12
commit-bot: I haz the power
5 years, 2 months ago (2015-10-09 15:56:02 UTC) #13
Message was sent while issue was closed.
Patchset 4 (id:??) landed as
https://crrev.com/d4cec0d8fa7913bc9dfa9137e44cca9098e16698
Cr-Commit-Position: refs/heads/master@{#10237}

Powered by Google App Engine
This is Rietveld 408576698