Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1467)

Unified Diff: talk/media/webrtc/webrtcvoiceengine.cc

Issue 1398823003: Remove MediaChannel::SetRemoteRenderer(). (Closed) Base URL: https://chromium.googlesource.com/external/webrtc.git@master
Patch Set: rebase Created 5 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « talk/media/webrtc/webrtcvoiceengine.h ('k') | talk/session/media/channel.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: talk/media/webrtc/webrtcvoiceengine.cc
diff --git a/talk/media/webrtc/webrtcvoiceengine.cc b/talk/media/webrtc/webrtcvoiceengine.cc
index 4d74e915c51441b3a4d403531dc7a87eeaa877c6..3fae1a742ddc9821d918cab2bf1be5d09967acc1 100644
--- a/talk/media/webrtc/webrtcvoiceengine.cc
+++ b/talk/media/webrtc/webrtcvoiceengine.cc
@@ -2389,29 +2389,6 @@ bool WebRtcVoiceMediaChannel::RemoveRecvStream(uint32_t ssrc) {
return true;
}
-bool WebRtcVoiceMediaChannel::SetRemoteRenderer(uint32_t ssrc,
- AudioRenderer* renderer) {
- RTC_DCHECK(thread_checker_.CalledOnValidThread());
- ChannelMap::iterator it = receive_channels_.find(ssrc);
- if (it == receive_channels_.end()) {
- if (renderer) {
- // Return an error if trying to set a valid renderer with an invalid ssrc.
- LOG(LS_ERROR) << "SetRemoteRenderer failed with ssrc "<< ssrc;
- return false;
- }
-
- // The channel likely has gone away, do nothing.
- return true;
- }
-
- if (renderer)
- it->second->Start(renderer);
- else
- it->second->Stop();
-
- return true;
-}
-
bool WebRtcVoiceMediaChannel::SetLocalRenderer(uint32_t ssrc,
AudioRenderer* renderer) {
ChannelMap::iterator it = send_channels_.find(ssrc);
« no previous file with comments | « talk/media/webrtc/webrtcvoiceengine.h ('k') | talk/session/media/channel.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698