talk/app/webrtc/webrtcsession_unittest.cc - Issue 1398823003: Remove MediaChannel::SetRemoteRenderer().

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: talk/app/webrtc/webrtcsession_unittest.cc

Issue 1398823003: Remove MediaChannel::SetRemoteRenderer(). (Closed) Base URL: https://chromium.googlesource.com/external/webrtc.git@master

Patch Set: rebase Created 5 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: talk/app/webrtc/webrtcsession_unittest.cc

diff --git a/talk/app/webrtc/webrtcsession_unittest.cc b/talk/app/webrtc/webrtcsession_unittest.cc

index e8624761e9e699bfbb3c15faca6eaa6676ace626..a463ba90bbecfddb81f8addb046b1fb63e9f3713 100644

--- a/talk/app/webrtc/webrtcsession_unittest.cc

+++ b/talk/app/webrtc/webrtcsession_unittest.cc

@@ -3101,11 +3101,10 @@ TEST_F(WebRtcSessionTest, SetAudioPlayout) {

double volume;

EXPECT_TRUE(channel->GetOutputVolume(receive_ssrc, &volume));

EXPECT_EQ(1, volume);

- rtc::scoped_ptr<FakeAudioRenderer> renderer(new FakeAudioRenderer());

- session_->SetAudioPlayout(receive_ssrc, false, renderer.get());

+ session_->SetAudioPlayout(receive_ssrc, false);

EXPECT_TRUE(channel->GetOutputVolume(receive_ssrc, &volume));

EXPECT_EQ(0, volume);

- session_->SetAudioPlayout(receive_ssrc, true, NULL);

+ session_->SetAudioPlayout(receive_ssrc, true);

EXPECT_TRUE(channel->GetOutputVolume(receive_ssrc, &volume));

EXPECT_EQ(1, volume);

}

« no previous file with comments | « talk/app/webrtc/webrtcsession.cc ('k') | talk/media/base/fakemediaengine.h » ('j') | no next file with comments »