Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(369)

Issue 1380603005: Revert of Change WebRTC SslCipher to be exposed as number only. (Closed)

Created:
5 years, 2 months ago by guoweis_webrtc
Modified:
5 years, 2 months ago
Base URL:
https://chromium.googlesource.com/external/webrtc@master
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

Revert of Change WebRTC SslCipher to be exposed as number only. (patchset #20 id:750001 of https://codereview.webrtc.org/1337673002/ ) Reason for revert: This broke chromium.fyi bot. Original issue's description: > Change WebRTC SslCipher to be exposed as number only. > > This makes the SSL exposed as uint16_t which is the IANA value. GetRfcSslCipherName is introduced to handle the conversion to names from ID. IANA value will be used for UMA reporting. Names will still be used for WebRTC stats reporting. > > For SRTP, currently it's still string internally but is reported as IANA number. > > This is used by the ongoing CL https://codereview.chromium.org/1335023002. > > BUG=523033 > > Committed: https://crrev.com/4fe3c9a77386598db9abd1f0d6983aefee9cc943 > Cr-Commit-Position: refs/heads/master@{#10124} TBR=juberti@webrtc.org,rsleevi@chromium.org,pthatcher@webrtc.org,davidben@chromium.org,juberti@google.com,davidben@webrtc.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=523033

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+287 lines, -332 lines) Patch
M talk/app/webrtc/fakemetricsobserver.h View 1 chunk +10 lines, -6 lines 0 comments Download
M talk/app/webrtc/fakemetricsobserver.cc View 2 chunks +26 lines, -11 lines 0 comments Download
M talk/app/webrtc/peerconnection_unittest.cc View 4 chunks +60 lines, -64 lines 0 comments Download
M talk/app/webrtc/peerconnectioninterface.h View 1 chunk +3 lines, -8 lines 0 comments Download
M talk/app/webrtc/statscollector.cc View 1 chunk +4 lines, -6 lines 0 comments Download
M talk/app/webrtc/statscollector_unittest.cc View 3 chunks +2 lines, -9 lines 0 comments Download
M talk/app/webrtc/umametrics.h View 2 chunks +6 lines, -7 lines 0 comments Download
M talk/app/webrtc/webrtcsession.cc View 1 chunk +14 lines, -15 lines 0 comments Download
M talk/session/media/channel.h View 4 chunks +4 lines, -5 lines 0 comments Download
M talk/session/media/channel.cc View 5 chunks +6 lines, -9 lines 0 comments Download
M talk/session/media/channel_unittest.cc View 4 chunks +7 lines, -7 lines 0 comments Download
M talk/session/media/mediasession.h View 1 chunk +1 line, -1 line 0 comments Download
M talk/session/media/mediasession.cc View 2 chunks +11 lines, -11 lines 0 comments Download
M talk/session/media/mediasession_unittest.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M talk/session/media/srtpfilter.h View 2 chunks +7 lines, -1 line 0 comments Download
M talk/session/media/srtpfilter.cc View 2 chunks +4 lines, -2 lines 0 comments Download
M talk/session/media/srtpfilter_unittest.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M webrtc/base/opensslstreamadapter.h View 2 chunks +8 lines, -8 lines 0 comments Download
M webrtc/base/opensslstreamadapter.cc View 7 chunks +45 lines, -52 lines 0 comments Download
M webrtc/base/sslstreamadapter.h View 3 chunks +6 lines, -28 lines 0 comments Download
M webrtc/base/sslstreamadapter.cc View 4 chunks +7 lines, -26 lines 0 comments Download
M webrtc/base/sslstreamadapter_unittest.cc View 2 chunks +27 lines, -27 lines 0 comments Download
M webrtc/p2p/base/dtlstransportchannel.h View 1 chunk +2 lines, -2 lines 0 comments Download
M webrtc/p2p/base/dtlstransportchannel.cc View 2 chunks +3 lines, -3 lines 0 comments Download
M webrtc/p2p/base/dtlstransportchannel_unittest.cc View 3 chunks +10 lines, -10 lines 0 comments Download
M webrtc/p2p/base/faketransportcontroller.h View 2 chunks +2 lines, -2 lines 0 comments Download
M webrtc/p2p/base/p2ptransportchannel.h View 1 chunk +2 lines, -2 lines 0 comments Download
M webrtc/p2p/base/transport.h View 1 chunk +2 lines, -2 lines 0 comments Download
M webrtc/p2p/base/transport.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M webrtc/p2p/base/transportchannel.h View 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
guoweis_webrtc
Created Revert of Change WebRTC SslCipher to be exposed as number only.
5 years, 2 months ago (2015-10-01 02:22:49 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1380603005/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1380603005/1
5 years, 2 months ago (2015-10-01 02:23:01 UTC) #2
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/27dc29b0df23eed5034f28d4d5f66ea0bb425d6c Cr-Commit-Position: refs/heads/master@{#10125}
5 years, 2 months ago (2015-10-01 02:23:20 UTC) #3
commit-bot: I haz the power
5 years, 2 months ago (2015-10-01 02:23:23 UTC) #4
Message was sent while issue was closed.
Committed patchset #1 (id:1)

Powered by Google App Engine
This is Rietveld 408576698