Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(200)

Side by Side Diff: talk/app/webrtc/peerconnectioninterface.h

Issue 1380603005: Revert of Change WebRTC SslCipher to be exposed as number only. (Closed) Base URL: https://chromium.googlesource.com/external/webrtc@master
Patch Set: Created 5 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « talk/app/webrtc/peerconnection_unittest.cc ('k') | talk/app/webrtc/statscollector.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 /* 1 /*
2 * libjingle 2 * libjingle
3 * Copyright 2012 Google Inc. 3 * Copyright 2012 Google Inc.
4 * 4 *
5 * Redistribution and use in source and binary forms, with or without 5 * Redistribution and use in source and binary forms, with or without
6 * modification, are permitted provided that the following conditions are met: 6 * modification, are permitted provided that the following conditions are met:
7 * 7 *
8 * 1. Redistributions of source code must retain the above copyright notice, 8 * 1. Redistributions of source code must retain the above copyright notice,
9 * this list of conditions and the following disclaimer. 9 * this list of conditions and the following disclaimer.
10 * 2. Redistributions in binary form must reproduce the above copyright notice, 10 * 2. Redistributions in binary form must reproduce the above copyright notice,
(...skipping 119 matching lines...) Expand 10 before | Expand all | Expand 10 after
130 class MetricsObserverInterface : public rtc::RefCountInterface { 130 class MetricsObserverInterface : public rtc::RefCountInterface {
131 public: 131 public:
132 132
133 // |type| is the type of the enum counter to be incremented. |counter| 133 // |type| is the type of the enum counter to be incremented. |counter|
134 // is the particular counter in that type. |counter_max| is the next sequence 134 // is the particular counter in that type. |counter_max| is the next sequence
135 // number after the highest counter. 135 // number after the highest counter.
136 virtual void IncrementEnumCounter(PeerConnectionEnumCounterType type, 136 virtual void IncrementEnumCounter(PeerConnectionEnumCounterType type,
137 int counter, 137 int counter,
138 int counter_max) {} 138 int counter_max) {}
139 139
140 // This is used to handle sparse counters like SSL cipher suites.
141 // TODO(guoweis): Remove the implementation once the dependency's interface
142 // definition is updated.
143 virtual void IncrementSparseEnumCounter(PeerConnectionEnumCounterType type,
144 int counter) {
145 IncrementEnumCounter(type, counter, 0 /* Ignored */);
146 }
147
148 virtual void AddHistogramSample(PeerConnectionMetricsName type, 140 virtual void AddHistogramSample(PeerConnectionMetricsName type,
149 int value) = 0; 141 int value) = 0;
142 // TODO(jbauch): Make method abstract when it is implemented by Chromium.
143 virtual void AddHistogramSample(PeerConnectionMetricsName type,
144 const std::string& value) {}
150 145
151 protected: 146 protected:
152 virtual ~MetricsObserverInterface() {} 147 virtual ~MetricsObserverInterface() {}
153 }; 148 };
154 149
155 typedef MetricsObserverInterface UMAObserver; 150 typedef MetricsObserverInterface UMAObserver;
156 151
157 class PeerConnectionInterface : public rtc::RefCountInterface { 152 class PeerConnectionInterface : public rtc::RefCountInterface {
158 public: 153 public:
159 // See http://dev.w3.org/2011/webrtc/editor/webrtc.html#state-definitions . 154 // See http://dev.w3.org/2011/webrtc/editor/webrtc.html#state-definitions .
(...skipping 477 matching lines...) Expand 10 before | Expand all | Expand 10 after
637 CreatePeerConnectionFactory( 632 CreatePeerConnectionFactory(
638 rtc::Thread* worker_thread, 633 rtc::Thread* worker_thread,
639 rtc::Thread* signaling_thread, 634 rtc::Thread* signaling_thread,
640 AudioDeviceModule* default_adm, 635 AudioDeviceModule* default_adm,
641 cricket::WebRtcVideoEncoderFactory* encoder_factory, 636 cricket::WebRtcVideoEncoderFactory* encoder_factory,
642 cricket::WebRtcVideoDecoderFactory* decoder_factory); 637 cricket::WebRtcVideoDecoderFactory* decoder_factory);
643 638
644 } // namespace webrtc 639 } // namespace webrtc
645 640
646 #endif // TALK_APP_WEBRTC_PEERCONNECTIONINTERFACE_H_ 641 #endif // TALK_APP_WEBRTC_PEERCONNECTIONINTERFACE_H_
OLDNEW
« no previous file with comments | « talk/app/webrtc/peerconnection_unittest.cc ('k') | talk/app/webrtc/statscollector.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698