Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3)

Side by Side Diff: talk/app/webrtc/umametrics.h

Issue 1380603005: Revert of Change WebRTC SslCipher to be exposed as number only. (Closed) Base URL: https://chromium.googlesource.com/external/webrtc@master
Patch Set: Created 5 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « talk/app/webrtc/statscollector_unittest.cc ('k') | talk/app/webrtc/webrtcsession.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 /* 1 /*
2 * libjingle 2 * libjingle
3 * Copyright 2014 Google Inc. 3 * Copyright 2014 Google Inc.
4 * 4 *
5 * Redistribution and use in source and binary forms, with or without 5 * Redistribution and use in source and binary forms, with or without
6 * modification, are permitted provided that the following conditions are met: 6 * modification, are permitted provided that the following conditions are met:
7 * 7 *
8 * 1. Redistributions of source code must retain the above copyright notice, 8 * 1. Redistributions of source code must retain the above copyright notice,
9 * this list of conditions and the following disclaimer. 9 * this list of conditions and the following disclaimer.
10 * 2. Redistributions in binary form must reproduce the above copyright notice, 10 * 2. Redistributions in binary form must reproduce the above copyright notice,
(...skipping 24 matching lines...) Expand all
35 // Used to specify which enum counter type we're incrementing in 35 // Used to specify which enum counter type we're incrementing in
36 // MetricsObserverInterface::IncrementEnumCounter. 36 // MetricsObserverInterface::IncrementEnumCounter.
37 enum PeerConnectionEnumCounterType { 37 enum PeerConnectionEnumCounterType {
38 kEnumCounterAddressFamily, 38 kEnumCounterAddressFamily,
39 // For the next 2 counters, we track them separately based on the "first hop" 39 // For the next 2 counters, we track them separately based on the "first hop"
40 // protocol used by the local candidate. "First hop" means the local candidate 40 // protocol used by the local candidate. "First hop" means the local candidate
41 // type in the case of non-TURN candidates, and the protocol used to connect 41 // type in the case of non-TURN candidates, and the protocol used to connect
42 // to the TURN server in the case of TURN candidates. 42 // to the TURN server in the case of TURN candidates.
43 kEnumCounterIceCandidatePairTypeUdp, 43 kEnumCounterIceCandidatePairTypeUdp,
44 kEnumCounterIceCandidatePairTypeTcp, 44 kEnumCounterIceCandidatePairTypeTcp,
45
46 kEnumCounterAudioSrtpCipher,
47 kEnumCounterAudioSslCipher,
48 kEnumCounterVideoSrtpCipher,
49 kEnumCounterVideoSslCipher,
50 kEnumCounterDataSrtpCipher,
51 kEnumCounterDataSslCipher,
52 kPeerConnectionEnumCounterMax 45 kPeerConnectionEnumCounterMax
53 }; 46 };
54 47
55 // Currently this contains information related to WebRTC network/transport 48 // Currently this contains information related to WebRTC network/transport
56 // information. 49 // information.
57 50
58 // The difference between PeerConnectionEnumCounter and 51 // The difference between PeerConnectionEnumCounter and
59 // PeerConnectionMetricsName is that the "EnumCounter" is only counting the 52 // PeerConnectionMetricsName is that the "EnumCounter" is only counting the
60 // occurrences of events, while "Name" has a value associated with it which is 53 // occurrences of events, while "Name" has a value associated with it which is
61 // used to form a histogram. 54 // used to form a histogram.
(...skipping 16 matching lines...) Expand all
78 // TODO(guoweis): Keep previous name here until all references are renamed. 71 // TODO(guoweis): Keep previous name here until all references are renamed.
79 typedef PeerConnectionAddressFamilyCounter PeerConnectionUMAMetricsCounter; 72 typedef PeerConnectionAddressFamilyCounter PeerConnectionUMAMetricsCounter;
80 73
81 // This enum defines types for UMA samples, which will have a range. 74 // This enum defines types for UMA samples, which will have a range.
82 enum PeerConnectionMetricsName { 75 enum PeerConnectionMetricsName {
83 kNetworkInterfaces_IPv4, // Number of IPv4 interfaces. 76 kNetworkInterfaces_IPv4, // Number of IPv4 interfaces.
84 kNetworkInterfaces_IPv6, // Number of IPv6 interfaces. 77 kNetworkInterfaces_IPv6, // Number of IPv6 interfaces.
85 kTimeToConnect, // In milliseconds. 78 kTimeToConnect, // In milliseconds.
86 kLocalCandidates_IPv4, // Number of IPv4 local candidates. 79 kLocalCandidates_IPv4, // Number of IPv4 local candidates.
87 kLocalCandidates_IPv6, // Number of IPv6 local candidates. 80 kLocalCandidates_IPv6, // Number of IPv6 local candidates.
81 kAudioSrtpCipher, // Name of SRTP cipher used in audio channel.
82 kAudioSslCipher, // Name of SSL cipher used in audio channel.
83 kVideoSrtpCipher, // Name of SRTP cipher used in video channel.
84 kVideoSslCipher, // Name of SSL cipher used in video channel.
85 kDataSrtpCipher, // Name of SRTP cipher used in data channel.
86 kDataSslCipher, // Name of SSL cipher used in data channel.
88 kPeerConnectionMetricsName_Max 87 kPeerConnectionMetricsName_Max
89 }; 88 };
90 89
91 // TODO(guoweis): Keep previous name here until all references are renamed. 90 // TODO(guoweis): Keep previous name here until all references are renamed.
92 typedef PeerConnectionMetricsName PeerConnectionUMAMetricsName; 91 typedef PeerConnectionMetricsName PeerConnectionUMAMetricsName;
93 92
94 // The IceCandidatePairType has the format of 93 // The IceCandidatePairType has the format of
95 // <local_candidate_type>_<remote_candidate_type>. It is recorded based on the 94 // <local_candidate_type>_<remote_candidate_type>. It is recorded based on the
96 // type of candidate pair used when the PeerConnection first goes to a completed 95 // type of candidate pair used when the PeerConnection first goes to a completed
97 // state. When BUNDLE is enabled, only the first transport gets recorded. 96 // state. When BUNDLE is enabled, only the first transport gets recorded.
(...skipping 21 matching lines...) Expand all
119 kIceCandidatePairHostPrivateHostPrivate, 118 kIceCandidatePairHostPrivateHostPrivate,
120 kIceCandidatePairHostPrivateHostPublic, 119 kIceCandidatePairHostPrivateHostPublic,
121 kIceCandidatePairHostPublicHostPrivate, 120 kIceCandidatePairHostPublicHostPrivate,
122 kIceCandidatePairHostPublicHostPublic, 121 kIceCandidatePairHostPublicHostPublic,
123 kIceCandidatePairMax 122 kIceCandidatePairMax
124 }; 123 };
125 124
126 } // namespace webrtc 125 } // namespace webrtc
127 126
128 #endif // TALK_APP_WEBRTC_UMAMETRICS_H_ 127 #endif // TALK_APP_WEBRTC_UMAMETRICS_H_
OLDNEW
« no previous file with comments | « talk/app/webrtc/statscollector_unittest.cc ('k') | talk/app/webrtc/webrtcsession.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698