Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(63)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1369263002: Unify Transport and newapi::Transport interfaces. (Closed)

Created:
5 years, 2 months ago by pbos-webrtc
Modified:
5 years, 2 months ago
Reviewers:
stefan-webrtc
CC:
webrtc-reviews_webrtc.org, interface-changes_webrtc.org, rwolff_gocast.it, hlundin-webrtc, yujie_mao (webrtc), Andrew MacDonald, henrika_webrtc, stefan-webrtc, tterriberry_mozilla.com, qiang.lu, niklas.enbom, andresp, peah-webrtc, the sun, perkj_webrtc, mflodman
Base URL:
https://chromium.googlesource.com/external/webrtc.git@master
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

Unify Transport and newapi::Transport interfaces. BUG=webrtc:1695 R=stefan@webrtc.org TBR=mflodman@webrtc.org Committed: https://crrev.com/2d566686a23fe93ada58f1c38a0d4b9a0d68556e Cr-Commit-Position: refs/heads/master@{#10096}

Patch Set 1 #

Total comments: 8

Patch Set 2 : self-review #

Unified diffs Side-by-side diffs Delta from patch set Stats (+150 lines, -207 lines) Patch
M talk/media/webrtc/webrtcvideoengine2.h View 1 chunk +1 line, -1 line 0 comments Download
M talk/media/webrtc/webrtcvoiceengine.h View 1 1 chunk +4 lines, -4 lines 0 comments Download
M webrtc/audio_send_stream.h View 2 chunks +2 lines, -2 lines 0 comments Download
M webrtc/call/transport_adapter.h View 1 chunk +5 lines, -5 lines 0 comments Download
M webrtc/call/transport_adapter.cc View 1 chunk +5 lines, -9 lines 0 comments Download
M webrtc/common_types.h View 1 chunk +0 lines, -11 lines 0 comments Download
M webrtc/modules/rtp_rtcp/source/nack_rtx_unittest.cc View 6 chunks +11 lines, -13 lines 0 comments Download
M webrtc/modules/rtp_rtcp/source/rtcp_format_remb_unittest.cc View 1 2 chunks +5 lines, -3 lines 0 comments Download
M webrtc/modules/rtp_rtcp/source/rtcp_receiver_unittest.cc View 1 1 chunk +4 lines, -4 lines 0 comments Download
M webrtc/modules/rtp_rtcp/source/rtcp_sender.h View 1 chunk +1 line, -0 lines 0 comments Download
M webrtc/modules/rtp_rtcp/source/rtcp_sender.cc View 1 2 chunks +2 lines, -2 lines 0 comments Download
M webrtc/modules/rtp_rtcp/source/rtcp_sender_unittest.cc View 1 1 chunk +4 lines, -4 lines 0 comments Download
M webrtc/modules/rtp_rtcp/source/rtp_rtcp_impl_unittest.cc View 1 2 chunks +4 lines, -4 lines 0 comments Download
M webrtc/modules/rtp_rtcp/source/rtp_sender.h View 1 chunk +1 line, -0 lines 0 comments Download
M webrtc/modules/rtp_rtcp/source/rtp_sender.cc View 1 chunk +2 lines, -1 line 0 comments Download
M webrtc/modules/rtp_rtcp/source/rtp_sender_unittest.cc View 1 3 chunks +13 lines, -13 lines 0 comments Download
M webrtc/modules/rtp_rtcp/test/testAPI/test_api.h View 2 chunks +4 lines, -3 lines 0 comments Download
M webrtc/modules/rtp_rtcp/test/testAPI/test_api.cc View 1 chunk +9 lines, -9 lines 0 comments Download
M webrtc/test/call_test.h View 1 chunk +2 lines, -2 lines 0 comments Download
M webrtc/test/call_test.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M webrtc/test/channel_transport/udp_transport.h View 1 1 chunk +1 line, -0 lines 0 comments Download
M webrtc/test/channel_transport/udp_transport_impl.h View 1 1 chunk +2 lines, -2 lines 0 comments Download
M webrtc/test/channel_transport/udp_transport_impl.cc View 1 3 chunks +15 lines, -15 lines 0 comments Download
M webrtc/test/direct_transport.h View 1 chunk +1 line, -1 line 0 comments Download
M webrtc/test/mock_transport.h View 1 chunk +3 lines, -3 lines 0 comments Download
M webrtc/test/null_transport.h View 1 chunk +1 line, -1 line 0 comments Download
M webrtc/test/rtp_rtcp_observer.h View 1 chunk +2 lines, -2 lines 0 comments Download
M webrtc/transport.h View 2 chunks +1 line, -2 lines 0 comments Download
M webrtc/video/end_to_end_tests.cc View 1 chunk +1 line, -1 line 0 comments Download
M webrtc/video/video_quality_test.h View 1 chunk +2 lines, -2 lines 0 comments Download
M webrtc/video/video_quality_test.cc View 2 chunks +3 lines, -3 lines 0 comments Download
M webrtc/video_receive_stream.h View 2 chunks +2 lines, -2 lines 0 comments Download
M webrtc/video_send_stream.h View 2 chunks +2 lines, -2 lines 0 comments Download
M webrtc/voice_engine/channel.h View 2 chunks +2 lines, -3 lines 0 comments Download
M webrtc/voice_engine/channel.cc View 3 chunks +15 lines, -34 lines 0 comments Download
M webrtc/voice_engine/include/voe_network.h View 1 chunk +1 line, -0 lines 0 comments Download
D webrtc/voice_engine/mock/mock_transport.h View 1 chunk +0 lines, -27 lines 0 comments Download
M webrtc/voice_engine/test/auto_test/fakes/conference_transport.h View 1 chunk +2 lines, -2 lines 0 comments Download
M webrtc/voice_engine/test/auto_test/fakes/conference_transport.cc View 1 chunk +4 lines, -4 lines 0 comments Download
M webrtc/voice_engine/test/auto_test/fixtures/after_initialization_fixture.h View 1 1 chunk +4 lines, -4 lines 0 comments Download
M webrtc/voice_engine/test/auto_test/standard/rtp_rtcp_extensions.cc View 1 2 chunks +4 lines, -4 lines 0 comments Download
M webrtc/voice_engine/voice_engine_fixture.h View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 18 (5 generated)
pbos-webrtc
PTAL, this updates all code to use the newapi::Transport interface (and removes newapi::).
5 years, 2 months ago (2015-09-28 13:32:48 UTC) #1
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1369263002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1369263002/1
5 years, 2 months ago (2015-09-28 13:33:12 UTC) #3
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: mac_asan on tryserver.webrtc (JOB_FAILED, http://build.chromium.org/p/tryserver.webrtc/builders/mac_asan/builds/9618)
5 years, 2 months ago (2015-09-28 13:37:21 UTC) #5
stefan-webrtc
https://codereview.webrtc.org/1369263002/diff/1/webrtc/modules/rtp_rtcp/source/rtcp_format_remb_unittest.cc File webrtc/modules/rtp_rtcp/source/rtcp_format_remb_unittest.cc (right): https://codereview.webrtc.org/1369263002/diff/1/webrtc/modules/rtp_rtcp/source/rtcp_format_remb_unittest.cc#newcode34 webrtc/modules/rtp_rtcp/source/rtcp_format_remb_unittest.cc:34: bool SendRtp(const uint8_t* /*data*/, size_t /*len*/) override { return ...
5 years, 2 months ago (2015-09-28 13:37:34 UTC) #6
pbos-webrtc
self-review
5 years, 2 months ago (2015-09-28 13:46:08 UTC) #7
pbos-webrtc
PTAL I think I cleaned up the things
5 years, 2 months ago (2015-09-28 13:47:02 UTC) #8
stefan-webrtc
lgtm
5 years, 2 months ago (2015-09-28 14:04:46 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1369263002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1369263002/20001
5 years, 2 months ago (2015-09-28 14:14:08 UTC) #11
pbos-webrtc
TBR=mflodman@ for root approval
5 years, 2 months ago (2015-09-28 14:16:51 UTC) #12
commit-bot: I haz the power
Try jobs failed on following builders: android_arm64_rel on tryserver.webrtc (JOB_TIMED_OUT, no build URL) android_dbg on ...
5 years, 2 months ago (2015-09-28 16:14:23 UTC) #14
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1369263002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1369263002/20001
5 years, 2 months ago (2015-09-28 16:35:38 UTC) #16
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 2 months ago (2015-09-28 16:59:37 UTC) #17
commit-bot: I haz the power
5 years, 2 months ago (2015-09-28 16:59:47 UTC) #18
Message was sent while issue was closed. 
Patchset 2 (id:??) landed as
https://crrev.com/2d566686a23fe93ada58f1c38a0d4b9a0d68556e
Cr-Commit-Position: refs/heads/master@{#10096}

Powered by Google App Engine
This is Rietveld 408576698