Unify Transport and newapi::Transport interfaces.

webrtc/modules/rtp_rtcp/source/rtcp_format_remb_unittest.cc

 /*
  *  Copyright (c) 2012 The WebRTC project authors. All Rights Reserved.
  *
  *  Use of this source code is governed by a BSD-style license
  *  that can be found in the LICENSE file in the root of the source
  *  tree. An additional intellectual property rights grant can be found
  *  in the file PATENTS.  All contributing project authors may
  *  be found in the AUTHORS file in the root of the source tree.
  */
 
@@ skipping 13 matching lines @@
 
 using namespace webrtc;
 
 
 class TestTransport : public Transport {
  public:
   TestTransport(RTCPReceiver* rtcp_receiver) :
     rtcp_receiver_(rtcp_receiver) {
   }
 
-  int SendPacket(const void* /*data*/, size_t /*len*/) override { return -1; }
-  int SendRTCPPacket(const void* packet, size_t packetLength) override {
+  bool SendRtp(const uint8_t* /*data*/, size_t /*len*/) override { return -1; }

[stefan-webrtc, 2015/09/28 13:37:33]

Implicit cast

+  bool SendRtcp(const uint8_t* packet, size_t packetLength) override {
     RTCPUtility::RTCPParserV2 rtcpParser((uint8_t*)packet,
                                          packetLength,
                                          true); // Allow non-compound RTCP
 
     EXPECT_TRUE(rtcpParser.IsValid());
     RTCPHelp::RTCPPacketInformation rtcpPacketInformation;
     EXPECT_EQ(0, rtcp_receiver_->IncomingRTCPPacket(rtcpPacketInformation,
                                                     &rtcpParser));
 
     EXPECT_EQ((uint32_t)kRtcpRemb,
               rtcpPacketInformation.rtcpPacketTypeFlags & kRtcpRemb);
     EXPECT_EQ((uint32_t)1234,
               rtcpPacketInformation.receiverEstimatedMaxBitrate);
     return static_cast<int>(packetLength);

[stefan-webrtc, 2015/09/28 13:37:33]

Implicit cast.

   }
  private:
   RTCPReceiver* rtcp_receiver_;
 };
 
 
 class RtcpFormatRembTest : public ::testing::Test {
  protected:
   RtcpFormatRembTest()
       : over_use_detector_options_(),
@@ skipping 62 matching lines @@
 
 TEST_F(RtcpFormatRembTest, TestCompund) {
   uint32_t SSRCs[2] = {456789, 98765};
   rtcp_sender_->SetRTCPStatus(kRtcpCompound);
   rtcp_sender_->SetREMBData(1234, std::vector<uint32_t>(SSRCs, SSRCs + 2));
   RTCPSender::FeedbackState feedback_state =
       dummy_rtp_rtcp_impl_->GetFeedbackState();
   EXPECT_EQ(0, rtcp_sender_->SendRTCP(feedback_state, kRtcpRemb));
 }
 }  // namespace