Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4)

Unified Diff: webrtc/test/channel_transport/udp_transport_impl.cc

Issue 1369263002: Unify Transport and newapi::Transport interfaces. (Closed) Base URL: https://chromium.googlesource.com/external/webrtc.git@master
Patch Set: self-review Created 5 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « webrtc/test/channel_transport/udp_transport_impl.h ('k') | webrtc/test/direct_transport.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: webrtc/test/channel_transport/udp_transport_impl.cc
diff --git a/webrtc/test/channel_transport/udp_transport_impl.cc b/webrtc/test/channel_transport/udp_transport_impl.cc
index e16c742c0037698324f173fb59d2e650f4eb2666..f66f4ef29d8158e609d5091d093cce5f22c45cf4 100644
--- a/webrtc/test/channel_transport/udp_transport_impl.cc
+++ b/webrtc/test/channel_transport/udp_transport_impl.cc
@@ -1931,18 +1931,18 @@ int32_t UdpTransportImpl::SendRTCPPacketTo(const int8_t* data,
return -1;
}
-int UdpTransportImpl::SendPacket(const void* data, size_t length) {
+bool UdpTransportImpl::SendRtp(const uint8_t* data, size_t length) {
WEBRTC_TRACE(kTraceStream, kTraceTransport, _id, "%s", __FUNCTION__);
CriticalSectionScoped cs(_crit);
if(_destIP[0] == 0)
{
- return -1;
+ return false;
}
if(_destPort == 0)
{
- return -1;
+ return false;
}
// Create socket if it hasn't been set up already.
@@ -1980,32 +1980,32 @@ int UdpTransportImpl::SendPacket(const void* data, size_t length) {
"SendPacket() failed to bind RTP socket");
_lastError = retVal;
CloseReceiveSockets();
- return -1;
+ return false;
}
}
if(_ptrSendRtpSocket)
{
return _ptrSendRtpSocket->SendTo((const int8_t*)data, length,
- _remoteRTPAddr);
+ _remoteRTPAddr) >= 0;
} else if(_ptrRtpSocket)
{
return _ptrRtpSocket->SendTo((const int8_t*)data, length,
- _remoteRTPAddr);
+ _remoteRTPAddr) >= 0;
}
- return -1;
+ return false;
}
-int UdpTransportImpl::SendRTCPPacket(const void* data, size_t length) {
+bool UdpTransportImpl::SendRtcp(const uint8_t* data, size_t length) {
CriticalSectionScoped cs(_crit);
if(_destIP[0] == 0)
{
- return -1;
+ return false;
}
if(_destPortRTCP == 0)
{
- return -1;
+ return false;
}
// Create socket if it hasn't been set up already.
@@ -2041,22 +2041,22 @@ int UdpTransportImpl::SendRTCPPacket(const void* data, size_t length) {
{
_lastError = retVal;
WEBRTC_TRACE(kTraceError, kTraceTransport, _id,
- "SendRTCPPacket() failed to bind RTCP socket");
+ "SendRtcp() failed to bind RTCP socket");
CloseReceiveSockets();
- return -1;
+ return false;
}
}
if(_ptrSendRtcpSocket)
{
return _ptrSendRtcpSocket->SendTo((const int8_t*)data, length,
- _remoteRTCPAddr);
+ _remoteRTCPAddr) >= 0;
} else if(_ptrRtcpSocket)
{
return _ptrRtcpSocket->SendTo((const int8_t*)data, length,
- _remoteRTCPAddr);
+ _remoteRTCPAddr) >= 0;
}
- return -1;
+ return false;
}
int32_t UdpTransportImpl::SetSendIP(const char* ipaddr)
« no previous file with comments | « webrtc/test/channel_transport/udp_transport_impl.h ('k') | webrtc/test/direct_transport.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698