Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(415)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1367923002: Android GlRectDrawer: Add test for RGB rendering (Closed)

Created:
5 years, 3 months ago by magjed_webrtc
Modified:
5 years, 3 months ago
Reviewers:
hbos
CC:
webrtc-reviews_webrtc.org, tterriberry_mozilla.com, qiang.lu, niklas.enbom, yujie_mao (webrtc), Andrew MacDonald
Base URL:
https://chromium.googlesource.com/external/webrtc.git@master
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

Android GlRectDrawer: Add test for RGB rendering BUG=webrtc:4742 R=hbos@webrtc.org Committed: https://crrev.com/6b20ad99e04f594a9a131bea5d80940698e6e8fd Cr-Commit-Position: refs/heads/master@{#10050}

Patch Set 1 #

Total comments: 2

Patch Set 2 : No alpha channel and add assertEquals() for RGB ByteBuffers #

Patch Set 3 : Remove unused variable #

Unified diffs Side-by-side diffs Delta from patch set Stats (+62 lines, -1 line) Patch
M talk/app/webrtc/androidtests/src/org/webrtc/GlRectDrawerTest.java View 1 2 1 chunk +62 lines, -1 line 0 comments Download

Messages

Total messages: 8 (1 generated)
magjed_webrtc
hbos - Please take a look.
5 years, 3 months ago (2015-09-24 09:34:07 UTC) #2
hbos
https://codereview.webrtc.org/1367923002/diff/1/talk/app/webrtc/androidtests/src/org/webrtc/GlRectDrawerTest.java File talk/app/webrtc/androidtests/src/org/webrtc/GlRectDrawerTest.java (right): https://codereview.webrtc.org/1367923002/diff/1/talk/app/webrtc/androidtests/src/org/webrtc/GlRectDrawerTest.java#newcode83 talk/app/webrtc/androidtests/src/org/webrtc/GlRectDrawerTest.java:83: GLES20.glReadPixels(0, 0, WIDTH, HEIGHT, GLES20.GL_RGBA, GLES20.GL_UNSIGNED_BYTE, data); Why read ...
5 years, 3 months ago (2015-09-24 11:37:39 UTC) #3
hbos
lgtm
5 years, 3 months ago (2015-09-24 11:39:20 UTC) #4
magjed_webrtc
https://codereview.webrtc.org/1367923002/diff/1/talk/app/webrtc/androidtests/src/org/webrtc/GlRectDrawerTest.java File talk/app/webrtc/androidtests/src/org/webrtc/GlRectDrawerTest.java (right): https://codereview.webrtc.org/1367923002/diff/1/talk/app/webrtc/androidtests/src/org/webrtc/GlRectDrawerTest.java#newcode83 talk/app/webrtc/androidtests/src/org/webrtc/GlRectDrawerTest.java:83: GLES20.glReadPixels(0, 0, WIDTH, HEIGHT, GLES20.GL_RGBA, GLES20.GL_UNSIGNED_BYTE, data); On 2015/09/24 ...
5 years, 3 months ago (2015-09-24 12:15:18 UTC) #5
magjed_webrtc
Committed patchset #3 (id:40001) manually as 6b20ad99e04f594a9a131bea5d80940698e6e8fd (presubmit successful).
5 years, 3 months ago (2015-09-24 13:05:41 UTC) #6
commit-bot: I haz the power
Patchset 3 (id:??) landed as https://crrev.com/6b20ad99e04f594a9a131bea5d80940698e6e8fd Cr-Commit-Position: refs/heads/master@{#10050}
5 years, 3 months ago (2015-09-24 13:05:46 UTC) #7
magjed_webrtc
5 years, 2 months ago (2015-09-24 16:15:52 UTC) #8
Message was sent while issue was closed. 
A revert of this CL (patchset #3 id:40001) has been created in
https://codereview.webrtc.org/1363613003/ by magjed@webrtc.org.

The reason for reverting is: The test fails on Nexus 9..

Powered by Google App Engine
This is Rietveld 408576698