Issue 1363613003: Revert of Android GlRectDrawer: Add test for RGB rendering

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1363613003: Revert of Android GlRectDrawer: Add test for RGB rendering (Closed)

Created:
5 years, 2 months ago by magjed_webrtc

Modified:
5 years, 2 months ago

Reviewers:
hbos

CC:
webrtc-reviews_webrtc.org, tterriberry_mozilla.com, qiang.lu, niklas.enbom, yujie_mao (webrtc), Andrew MacDonald

Base URL:
https://chromium.googlesource.com/external/webrtc.git@master

Target Ref:
refs/pending/heads/master

Project:
webrtc

Visibility:
Public.

More Reviews

Description

Revert of Android GlRectDrawer: Add test for RGB rendering (patchset #3 id:40001 of https://codereview.webrtc.org/1367923002/ ) Reason for revert: The test fails on Nexus 9. Original issue's description: > Android GlRectDrawer: Add test for RGB rendering > > BUG=webrtc:4742 > R=hbos@webrtc.org > > Committed: https://crrev.com/6b20ad99e04f594a9a131bea5d80940698e6e8fd > Cr-Commit-Position: refs/heads/master@{#10050} TBR=hbos@webrtc.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=webrtc:4742 Committed: https://crrev.com/5e9a1bc79066eb8d8be62a12da921ee7b430ab9f Cr-Commit-Position: refs/heads/master@{#10058}

Patch Set 1 #

Created: 5 years, 2 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+1 line, -62 lines)			Patch
	M	talk/app/webrtc/androidtests/src/org/webrtc/GlRectDrawerTest.java	View		1 chunk	+1 line, -62 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

magjed_webrtc

Created Revert of Android GlRectDrawer: Add test for RGB rendering

5 years, 2 months ago (2015-09-24 16:15:53 UTC) #1

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1363613003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1363613003/1

5 years, 2 months ago (2015-09-24 16:16:08 UTC) #2

commit-bot: I haz the power

5 years, 2 months ago (2015-09-24 16:16:26 UTC) #4

Message was sent while issue was closed.

Patchset 1 (id:??) landed as
https://crrev.com/5e9a1bc79066eb8d8be62a12da921ee7b430ab9f
Cr-Commit-Position: refs/heads/master@{#10058}

Expand Messages | Collapse Messages