Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(621)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1362303002: Reland "Wire up send-side bandwidth estimation." (Closed)

Created:
5 years, 3 months ago by sprang_webrtc
Modified:
5 years, 3 months ago
Reviewers:
stefan-webrtc
CC:
webrtc-reviews_webrtc.org, yujie_mao (webrtc), tterriberry_mozilla.com, mflodman, the sun, perkj_webrtc, andresp
Base URL:
https://chromium.googlesource.com/external/webrtc.git@master
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

Reland "Wire up send-side bandwidth estimation." Revert was patchset #8 id:140001 of https://codereview.webrtc.org/1338203003/ The culprit was RTC_DCHECK(poller_thread_->Start()); in rampup_test.cc BUG=webrtc:4173 R=stefan@webrtc.org Committed: https://crrev.com/6b8d3551681f40b880507cecc88f478a12383cc7 Cr-Commit-Position: refs/heads/master@{#10052}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+429 lines, -111 lines) Patch
M webrtc/modules/modules.gyp View 1 chunk +1 line, -0 lines 0 comments Download
M webrtc/modules/remote_bitrate_estimator/BUILD.gn View 1 chunk +4 lines, -0 lines 0 comments Download
M webrtc/modules/remote_bitrate_estimator/transport_feedback_adapter.cc View 1 chunk +1 line, -0 lines 0 comments Download
M webrtc/modules/rtp_rtcp/interface/rtp_rtcp_defines.h View 1 chunk +2 lines, -1 line 0 comments Download
M webrtc/modules/rtp_rtcp/source/rtcp_format_remb_unittest.cc View 2 chunks +7 lines, -3 lines 0 comments Download
M webrtc/modules/rtp_rtcp/source/rtcp_packet.h View 2 chunks +3 lines, -1 line 0 comments Download
M webrtc/modules/rtp_rtcp/source/rtcp_receiver.h View 4 chunks +9 lines, -0 lines 0 comments Download
M webrtc/modules/rtp_rtcp/source/rtcp_receiver.cc View 9 chunks +48 lines, -3 lines 0 comments Download
M webrtc/modules/rtp_rtcp/source/rtcp_receiver_help.h View 2 chunks +5 lines, -0 lines 0 comments Download
M webrtc/modules/rtp_rtcp/source/rtcp_receiver_help.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M webrtc/modules/rtp_rtcp/source/rtcp_receiver_unittest.cc View 12 chunks +17 lines, -16 lines 0 comments Download
M webrtc/modules/rtp_rtcp/source/rtcp_sender.h View 1 chunk +0 lines, -3 lines 0 comments Download
M webrtc/modules/rtp_rtcp/source/rtcp_utility.h View 4 chunks +11 lines, -0 lines 0 comments Download
M webrtc/modules/rtp_rtcp/source/rtcp_utility.cc View 12 chunks +46 lines, -34 lines 0 comments Download
M webrtc/modules/rtp_rtcp/source/rtp_rtcp_impl.cc View 1 chunk +1 line, -0 lines 0 comments Download
M webrtc/video/end_to_end_tests.cc View 2 chunks +63 lines, -0 lines 0 comments Download
M webrtc/video/rampup_tests.h View 4 chunks +6 lines, -0 lines 0 comments Download
M webrtc/video/rampup_tests.cc View 8 chunks +95 lines, -0 lines 0 comments Download
M webrtc/video/screenshare_loopback.cc View 2 chunks +8 lines, -13 lines 0 comments Download
M webrtc/video/video_loopback.cc View 2 chunks +9 lines, -13 lines 0 comments Download
M webrtc/video/video_quality_test.h View 1 chunk +1 line, -0 lines 0 comments Download
M webrtc/video/video_quality_test.cc View 2 chunks +11 lines, -0 lines 0 comments Download
M webrtc/video/video_receive_stream.cc View 1 chunk +1 line, -1 line 0 comments Download
M webrtc/video/video_send_stream.cc View 1 chunk +1 line, -1 line 0 comments Download
M webrtc/video_engine/vie_channel_group.h View 4 chunks +12 lines, -5 lines 0 comments Download
M webrtc/video_engine/vie_channel_group.cc View 9 chunks +65 lines, -15 lines 0 comments Download

Messages

Total messages: 5 (1 generated)
sprang_webrtc
5 years, 3 months ago (2015-09-24 09:43:33 UTC) #2
stefan-webrtc
On 2015/09/24 09:43:33, språng wrote: lgtm
5 years, 3 months ago (2015-09-24 11:52:27 UTC) #3
sprang_webrtc
Committed patchset #1 (id:1) manually as 6b8d3551681f40b880507cecc88f478a12383cc7 (presubmit successful).
5 years, 3 months ago (2015-09-24 13:07:22 UTC) #4
commit-bot: I haz the power
5 years, 3 months ago (2015-09-24 13:07:25 UTC) #5
Message was sent while issue was closed. 
Patchset 1 (id:??) landed as
https://crrev.com/6b8d3551681f40b880507cecc88f478a12383cc7
Cr-Commit-Position: refs/heads/master@{#10052}

Powered by Google App Engine
This is Rietveld 408576698