Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(80)

Unified Diff: webrtc/video/screenshare_loopback.cc

Issue 1362303002: Reland "Wire up send-side bandwidth estimation." (Closed) Base URL: https://chromium.googlesource.com/external/webrtc.git@master
Patch Set: Created 5 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « webrtc/video/rampup_tests.cc ('k') | webrtc/video/video_loopback.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: webrtc/video/screenshare_loopback.cc
diff --git a/webrtc/video/screenshare_loopback.cc b/webrtc/video/screenshare_loopback.cc
index 34f68947f660e84fc342196a019fa9778a1ec443..9897783eb9ddf8ff59d644722b624943b403978c 100644
--- a/webrtc/video/screenshare_loopback.cc
+++ b/webrtc/video/screenshare_loopback.cc
@@ -139,6 +139,8 @@ int DurationSecs() {
return static_cast<int>(FLAGS_duration);
}
+DEFINE_bool(send_side_bwe, true, "Use send-side bandwidth estimation");
+
DEFINE_string(
force_fieldtrials,
"",
@@ -162,19 +164,12 @@ void Loopback() {
call_bitrate_config.max_bitrate_bps = flags::MaxBitrateKbps() * 1000;
VideoQualityTest::Params params{
- {
- flags::Width(),
- flags::Height(),
- flags::Fps(),
- flags::MinBitrateKbps() * 1000,
- flags::TargetBitrateKbps() * 1000,
- flags::MaxBitrateKbps() * 1000,
- flags::Codec(),
- flags::NumTemporalLayers(),
- flags::MinTransmitBitrateKbps() * 1000,
- call_bitrate_config,
- flags::TLDiscardThreshold()
- },
+ {flags::Width(), flags::Height(), flags::Fps(),
+ flags::MinBitrateKbps() * 1000, flags::TargetBitrateKbps() * 1000,
+ flags::MaxBitrateKbps() * 1000, flags::Codec(),
+ flags::NumTemporalLayers(), flags::MinTransmitBitrateKbps() * 1000,
+ call_bitrate_config, flags::TLDiscardThreshold(),
+ flags::FLAGS_send_side_bwe},
{}, // Video specific.
{true, flags::SlideChangeInterval(), flags::ScrollDuration()},
{"screenshare", 0.0, 0.0, flags::DurationSecs(), flags::OutputFilename()},
« no previous file with comments | « webrtc/video/rampup_tests.cc ('k') | webrtc/video/video_loopback.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698