Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(204)

Unified Diff: webrtc/video/video_loopback.cc

Issue 1362303002: Reland "Wire up send-side bandwidth estimation." (Closed) Base URL: https://chromium.googlesource.com/external/webrtc.git@master
Patch Set: Created 5 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « webrtc/video/screenshare_loopback.cc ('k') | webrtc/video/video_quality_test.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: webrtc/video/video_loopback.cc
diff --git a/webrtc/video/video_loopback.cc b/webrtc/video/video_loopback.cc
index c5e9254c087ff4a106903885be2797e56551657e..0dceea82e6ea45e5f85bbfa7e5844036ac7a9956 100644
--- a/webrtc/video/video_loopback.cc
+++ b/webrtc/video/video_loopback.cc
@@ -140,6 +140,8 @@ int DurationSecs() {
return static_cast<int>(FLAGS_duration);
}
+DEFINE_bool(send_side_bwe, true, "Use send-side bandwidth estimation");
+
} // namespace flags
void Loopback() {
@@ -158,19 +160,13 @@ void Loopback() {
std::string clip = flags::Clip();
std::string graph_title = clip.empty() ? "" : "video " + clip;
VideoQualityTest::Params params{
- {
- flags::Width(),
- flags::Height(),
- flags::Fps(),
- flags::MinBitrateKbps() * 1000,
- flags::TargetBitrateKbps() * 1000,
- flags::MaxBitrateKbps() * 1000,
- flags::Codec(),
- flags::NumTemporalLayers(),
- 0, // No min transmit bitrate.
- call_bitrate_config,
- flags::TLDiscardThreshold()
- },
+ {flags::Width(), flags::Height(), flags::Fps(),
+ flags::MinBitrateKbps() * 1000, flags::TargetBitrateKbps() * 1000,
+ flags::MaxBitrateKbps() * 1000, flags::Codec(),
+ flags::NumTemporalLayers(),
+ 0, // No min transmit bitrate.
+ call_bitrate_config, flags::TLDiscardThreshold(),
+ flags::FLAGS_send_side_bwe},
{clip},
{}, // Screenshare specific.
{graph_title, 0.0, 0.0, flags::DurationSecs(), flags::OutputFilename()},
« no previous file with comments | « webrtc/video/screenshare_loopback.cc ('k') | webrtc/video/video_quality_test.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698