Issue 1360203003: Address the comment from 1367553002

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1360203003: Address the comment from 1367553002 (Closed)

Created:
5 years, 3 months ago by guoweis_webrtc

Modified:
5 years, 3 months ago

Reviewers:
juberti

CC:
webrtc-reviews_webrtc.org, tterriberry_mozilla.com

Base URL:
https://chromium.googlesource.com/external/webrtc@master

Target Ref:
refs/pending/heads/master

Project:
webrtc

Visibility:
Public.

More Reviews

Description

Address the comment from 1367553002. Remove duplication introduced by https://codereview.webrtc.org/1367553002 BUG=webrtc:5030 TBR=juberti@webrtc.org Committed: https://crrev.com/53eee43e7873d5de2ae015b48c1c353dc0a32d92 Cr-Commit-Position: refs/heads/master@{#10039}

Patch Set 1 #

Created: 5 years, 3 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+12 lines, -12 lines)			Patch
	M	webrtc/p2p/base/tcpport.cc	View		1 chunk	+12 lines, -12 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

guoweis_webrtc

Committed patchset #1 (id:1) manually as 53eee43e7873d5de2ae015b48c1c353dc0a32d92 (presubmit successful).

5 years, 3 months ago (2015-09-23 21:09:42 UTC) #1

commit-bot: I haz the power

Patchset 1 (id:??) landed as https://crrev.com/53eee43e7873d5de2ae015b48c1c353dc0a32d92 Cr-Commit-Position: refs/heads/master@{#10039}

5 years, 3 months ago (2015-09-23 21:09:46 UTC) #2

juberti

5 years, 3 months ago (2015-09-23 21:19:51 UTC) #3

Message was sent while issue was closed.

On 2015/09/23 21:09:46, commit-bot: I haz the power wrote:
> Patchset 1 (id:??) landed as
> https://crrev.com/53eee43e7873d5de2ae015b48c1c353dc0a32d92
> Cr-Commit-Position: refs/heads/master@{#10039}

lgtm

Expand Messages | Collapse Messages