TcpPort doesn't connect when calling gmail with non-proxied UDP disabled

TcpPort doesn't connect when calling gmail with non-proxied UDP disabled.

The same check has been made into turnport.cc but missed this place.

BUG=webrtc:5030
R=pthatcher@webrtc.org

Committed: https://crrev.com/2e4b620471efdd913e2d9975b9d0b49b3e50f3a7
Cr-Commit-Position: refs/heads/master@{#10038}

[guoweis_webrtc, 2015-09-23 17:06:58]

guoweis@webrtc.org changed reviewers:
+ juberti@webrtc.org, pthatcher@webrtc.org

[guoweis_webrtc, 2015-09-23 17:06:59]

PTAL.

[pthatcher1, 2015-09-23 19:42:13]

lgtm for expediency, but I would like to see a unit test.  So even if you submit
right away, please make a followup CL for a unit test.

[pthatcher1, 2015-09-23 19:42:13]

lgtm for expediency, but I would like to see a unit test.  So even if you submit
right away, please make a followup CL for a unit test.

[guoweis_webrtc, 2015-09-23 19:43:42]

On 2015/09/23 19:42:13, pthatcher1 wrote:
> lgtm for expediency, but I would like to see a unit test.  So even if you
submit
> right away, please make a followup CL for a unit test.

sounds good. will add test case once other high pri tasks are done.

[guoweis_webrtc, 2015-09-23 19:43:43]

The CQ bit was checked by guoweis@webrtc.org

[commit-bot: I haz the power, 2015-09-23 19:43:58]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1367553002/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1367553002/20001

[commit-bot: I haz the power, 2015-09-23 20:33:59]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-09-23 20:34:00]

Try jobs failed on following builders:
  win_x64_gn_dbg on tryserver.webrtc (JOB_FAILED,
http://build.chromium.org/p/tryserver.webrtc/builders/win_x64_gn_dbg/builds/4157)

[guoweis_webrtc, 2015-09-23 20:57:23]

Committed patchset #2 (id:20001) manually as
2e4b620471efdd913e2d9975b9d0b49b3e50f3a7 (presubmit successful).

[commit-bot: I haz the power, 2015-09-23 20:57:27]

Patchset 2 (id:??) landed as
https://crrev.com/2e4b620471efdd913e2d9975b9d0b49b3e50f3a7
Cr-Commit-Position: refs/heads/master@{#10038}

[juberti, 2015-09-23 21:00:15]

juberti@google.com changed reviewers:
+ juberti@google.com

[juberti, 2015-09-23 21:00:15]

lgtm with comment, agree on unit test

https://codereview.webrtc.org/1367553002/diff/20001/webrtc/p2p/base/tcpport.cc
File webrtc/p2p/base/tcpport.cc (right):

https://codereview.webrtc.org/1367553002/diff/20001/webrtc/p2p/base/tcpport.c...
webrtc/p2p/base/tcpport.cc:382: } else if (IPIsAny(port()->ip())) {
I would have just combined this into the case above, rather than duplicating the
code here.

[guoweis_webrtc, 2015-09-23 21:09:48]

On 2015/09/23 21:00:15, juberti wrote:
> lgtm with comment, agree on unit test
> 
> https://codereview.webrtc.org/1367553002/diff/20001/webrtc/p2p/base/tcpport.cc
> File webrtc/p2p/base/tcpport.cc (right):
> 
>
https://codereview.webrtc.org/1367553002/diff/20001/webrtc/p2p/base/tcpport.c...
> webrtc/p2p/base/tcpport.cc:382: } else if (IPIsAny(port()->ip())) {
> I would have just combined this into the case above, rather than duplicating
the
> code here.

landed https://codereview.webrtc.org/1360203003/ for that.