Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(14)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1360173003: Remove last use of ACMAMRPackingFormat (Closed)

Created:
5 years, 2 months ago by hlundin-webrtc
Modified:
5 years, 2 months ago
Reviewers:
åsapersson
CC:
webrtc-reviews_webrtc.org, tterriberry_mozilla.com, hlundin-webrtc, kwiberg-webrtc, tlegrand-webrtc
Base URL:
https://chromium.googlesource.com/external/webrtc.git@util-codec-remove-amr
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

Remove last use of ACMAMRPackingFormat It was no-op used in FileRecorder. BUG=webrtc:3520 Committed: https://crrev.com/fb9e76369d3270ba7f4272012a136adafe25745e Cr-Commit-Position: refs/heads/master@{#10102}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -42 lines) Patch
M webrtc/modules/audio_coding/main/interface/audio_coding_module_typedefs.h View 1 chunk +0 lines, -19 lines 0 comments Download
M webrtc/modules/utility/interface/file_recorder.h View 3 chunks +2 lines, -6 lines 0 comments Download
M webrtc/modules/utility/source/file_recorder_impl.h View 3 chunks +3 lines, -8 lines 0 comments Download
M webrtc/modules/utility/source/file_recorder_impl.cc View 3 chunks +2 lines, -9 lines 0 comments Download

Depends on Patchset:

Issue 1365283002 Patch 1

Messages

Total messages: 11 (4 generated)
hlundin-webrtc
Åsa, Please, take a look at this CL, removing the last use of ACMAMRPackingFormat. Thanks! ...
5 years, 2 months ago (2015-09-28 14:08:47 UTC) #2
åsapersson
lgtm
5 years, 2 months ago (2015-09-28 15:39:00 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1360173003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1360173003/1
5 years, 2 months ago (2015-09-28 18:54:30 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: android_arm64_rel on tryserver.webrtc (JOB_TIMED_OUT, no build URL) android_dbg on ...
5 years, 2 months ago (2015-09-28 20:54:47 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1360173003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1360173003/1
5 years, 2 months ago (2015-09-29 06:29:27 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 2 months ago (2015-09-29 06:30:26 UTC) #10
commit-bot: I haz the power
5 years, 2 months ago (2015-09-29 06:30:42 UTC) #11
Message was sent while issue was closed. 
Patchset 1 (id:??) landed as
https://crrev.com/fb9e76369d3270ba7f4272012a136adafe25745e
Cr-Commit-Position: refs/heads/master@{#10102}

Powered by Google App Engine
This is Rietveld 408576698