Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(893)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1365283002: Remove AMR format parameter from AudioCoder in utility (Closed)

Created:
5 years, 2 months ago by hlundin-webrtc
Modified:
5 years, 2 months ago
Reviewers:
åsapersson
CC:
webrtc-reviews_webrtc.org, tterriberry_mozilla.com, kwiberg-webrtc
Base URL:
https://chromium.googlesource.com/external/webrtc.git@acm-cleanup-typedefs.h
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

Remove AMR format parameter from AudioCoder in utility The parameter was never used. BUG=webrtc:3520 Committed: https://crrev.com/8387c5f449c6cfcf6fe604489439efdb889e0c05 Cr-Commit-Position: refs/heads/master@{#10095}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -12 lines) Patch
M webrtc/modules/utility/source/coder.h View 1 chunk +2 lines, -6 lines 0 comments Download
M webrtc/modules/utility/source/coder.cc View 2 chunks +2 lines, -4 lines 0 comments Download
M webrtc/modules/utility/source/file_player_impl.cc View 1 chunk +1 line, -1 line 0 comments Download
M webrtc/modules/utility/source/file_recorder_impl.cc View 1 chunk +1 line, -1 line 0 comments Download

Depends on Patchset:

Issue 1364703007 Patch 1

Dependent Patchsets:

Issue 1360173003 Patch 1

Messages

Total messages: 7 (2 generated)
hlundin-webrtc
Åsa, Please, take a look at this CL. Thanks! /HL
5 years, 2 months ago (2015-09-28 11:48:29 UTC) #2
åsapersson
lgtm bug->webrtc:3520
5 years, 2 months ago (2015-09-28 11:55:26 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1365283002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1365283002/1
5 years, 2 months ago (2015-09-28 14:06:43 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 2 months ago (2015-09-28 16:24:54 UTC) #6
commit-bot: I haz the power
5 years, 2 months ago (2015-09-28 16:25:05 UTC) #7
Message was sent while issue was closed. 
Patchset 1 (id:??) landed as
https://crrev.com/8387c5f449c6cfcf6fe604489439efdb889e0c05
Cr-Commit-Position: refs/heads/master@{#10095}

Powered by Google App Engine
This is Rietveld 408576698