webrtc/modules/utility/interface/file_recorder.h - Issue 1360173003: Remove last use of ACMAMRPackingFormat

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: webrtc/modules/utility/interface/file_recorder.h

Issue 1360173003: Remove last use of ACMAMRPackingFormat (Closed) Base URL: https://chromium.googlesource.com/external/webrtc.git@util-codec-remove-amr

Patch Set: Created 5 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « webrtc/modules/audio_coding/main/interface/audio_coding_module_typedefs.h ('k') | webrtc/modules/utility/source/file_recorder_impl.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: webrtc/modules/utility/interface/file_recorder.h

diff --git a/webrtc/modules/utility/interface/file_recorder.h b/webrtc/modules/utility/interface/file_recorder.h

index 009fa7510e28dbd58e78dd7a33ca3ddee1ee7fb9..1e12673eebc762f98cb2cb9de53e0309f9d2b610 100644

--- a/webrtc/modules/utility/interface/file_recorder.h

+++ b/webrtc/modules/utility/interface/file_recorder.h

@@ -13,7 +13,6 @@

#include "webrtc/common_types.h"

#include "webrtc/engine_configurations.h"

-#include "webrtc/modules/audio_coding/main/interface/audio_coding_module_typedefs.h"

#include "webrtc/modules/interface/module_common_types.h"

#include "webrtc/modules/media_file/interface/media_file_defines.h"

#include "webrtc/system_wrappers/interface/tick_util.h"

@@ -40,14 +39,12 @@ public:

virtual int32_t StartRecordingAudioFile(

const char* fileName,

const CodecInst& codecInst,

- uint32_t notification,

- ACMAMRPackingFormat amrFormat = AMRFileStorage) = 0;

+ uint32_t notification) = 0;

virtual int32_t StartRecordingAudioFile(

OutStream& destStream,

const CodecInst& codecInst,

- uint32_t notification,

- ACMAMRPackingFormat amrFormat = AMRFileStorage) = 0;

+ uint32_t notification) = 0;

// Stop recording.

// Note: this API is for both audio and video.

@@ -74,7 +71,6 @@ public:

const char* fileName,

const CodecInst& audioCodecInst,

const VideoCodec& videoCodecInst,

- ACMAMRPackingFormat amrFormat = AMRFileStorage,

bool videoOnly = false) = 0;

// Record the video frame in videoFrame to AVI file.