Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(66)

Issue 1353763002: Remove ACM AudioCodingFeedback callback object and derived classes (Closed)

Created:
5 years, 3 months ago by hlundin-webrtc
Modified:
5 years, 3 months ago
CC:
webrtc-reviews_webrtc.org, interface-changes_webrtc.org, rwolff_gocast.it, yujie_mao (webrtc), Andrew MacDonald, hlundin-webrtc, tlegrand-webrtc, tterriberry_mozilla.com, qiang.lu, niklas.enbom, kwiberg-webrtc
Base URL:
https://chromium.googlesource.com/external/webrtc.git@acm-remove-dtmf-api
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

Remove ACM AudioCodingFeedback callback object and derived classes The callback object was not used anymore. Also removing the deprecated WEBRTC_DTMF_DETECTION macro from engine_configurations.h. BUG=3520 Committed: https://crrev.com/e510d7f100f716048a216e2786617d1bbd5bb815 Cr-Commit-Position: refs/heads/master@{#9988}

Patch Set 1 #

Total comments: 2

Patch Set 2 : Fix an error introduced in first patch set #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -78 lines) Patch
M webrtc/engine_configurations.h View 1 chunk +0 lines, -6 lines 0 comments Download
M webrtc/modules/audio_coding/main/interface/audio_coding_module.h View 1 chunk +0 lines, -9 lines 0 comments Download
M webrtc/modules/audio_coding/main/test/APITest.h View 1 chunk +0 lines, -1 line 0 comments Download
M webrtc/modules/audio_coding/main/test/APITest.cc View 1 3 chunks +0 lines, -5 lines 0 comments Download
M webrtc/modules/audio_coding/main/test/TwoWayCommunication.cc View 4 chunks +0 lines, -18 lines 0 comments Download
M webrtc/modules/audio_coding/main/test/utility.h View 1 chunk +0 lines, -13 lines 0 comments Download
M webrtc/modules/audio_coding/main/test/utility.cc View 1 chunk +0 lines, -26 lines 0 comments Download

Depends on Patchset:

Messages

Total messages: 16 (5 generated)
hlundin-webrtc
Please, take a look. kwiberg: all tina.legrand: engine_configurations.h
5 years, 3 months ago (2015-09-17 09:11:34 UTC) #2
kwiberg-webrtc
lgtm
5 years, 3 months ago (2015-09-17 10:54:01 UTC) #3
tlegrand-webrtc
I think you might have introduce a bug. Can you take a look at my ...
5 years, 3 months ago (2015-09-18 08:36:56 UTC) #4
hlundin-webrtc
Fix an error introduced in first patch set
5 years, 3 months ago (2015-09-18 09:00:03 UTC) #5
hlundin-webrtc
PTAL again. https://codereview.webrtc.org/1353763002/diff/1/webrtc/modules/audio_coding/main/test/APITest.cc File webrtc/modules/audio_coding/main/test/APITest.cc (right): https://codereview.webrtc.org/1353763002/diff/1/webrtc/modules/audio_coding/main/test/APITest.cc#newcode127 webrtc/modules/audio_coding/main/test/APITest.cc:127: DELETE_POINTER(_vadCallbackA); On 2015/09/18 08:36:55, tlegrand-webrtc wrote: > ...
5 years, 3 months ago (2015-09-18 09:01:13 UTC) #6
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1353763002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1353763002/20001
5 years, 3 months ago (2015-09-18 09:01:39 UTC) #8
tlegrand-webrtc
lgtm
5 years, 3 months ago (2015-09-18 09:23:05 UTC) #9
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
5 years, 3 months ago (2015-09-18 10:38:06 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1353763002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1353763002/20001
5 years, 3 months ago (2015-09-18 10:55:23 UTC) #14
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 3 months ago (2015-09-18 10:56:11 UTC) #15
commit-bot: I haz the power
5 years, 3 months ago (2015-09-18 10:56:26 UTC) #16
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/e510d7f100f716048a216e2786617d1bbd5bb815
Cr-Commit-Position: refs/heads/master@{#9988}

Powered by Google App Engine
This is Rietveld 408576698