Chromium Code Reviews
Help | Chromium Project | Gerrit Changes | Sign in
(5)

Issue 1356543003: ACM: Remove functions related to DTMF (Closed)

Created:
3 years, 1 month ago by hlundin-webrtc
Modified:
3 years, 1 month ago
CC:
webrtc-reviews_webrtc.org, tterriberry_mozilla.com, hlundin-webrtc, henrika_webrtc, kwiberg-webrtc, tlegrand-webrtc
Base URL:
https://chromium.googlesource.com/external/webrtc.git@master
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

ACM: Remove functions related to DTMF The functions were essentially no-op. Also removing forward declaration of ACMDTMFDetection, which was not used. BUG=3520 Committed: https://crrev.com/061b79af6023b6caf9975be39fe53dd0ec3b7464 Cr-Commit-Position: refs/heads/master@{#9982}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -51 lines) Patch
M webrtc/modules/audio_coding/main/acm2/audio_coding_module.cc View 1 chunk +0 lines, -1 line 0 comments Download
M webrtc/modules/audio_coding/main/acm2/audio_coding_module_impl.h View 2 chunks +0 lines, -12 lines 0 comments Download
M webrtc/modules/audio_coding/main/acm2/audio_coding_module_impl.cc View 2 chunks +0 lines, -9 lines 0 comments Download
M webrtc/modules/audio_coding/main/interface/audio_coding_module.h View 2 chunks +0 lines, -26 lines 0 comments Download
M webrtc/voice_engine/channel.cc View 1 chunk +1 line, -3 lines 0 comments Download

Dependent Patchsets:

Messages

Total messages: 12 (4 generated)
hlundin-webrtc
Please, take a look. kwiberg: all henrikg: voice_engine
3 years, 1 month ago (2015-09-17 09:10:28 UTC) #2
Henrik Grunell WebRTC
voice_engine lgtm
3 years, 1 month ago (2015-09-17 09:52:33 UTC) #3
kwiberg-webrtc
lgtm
3 years, 1 month ago (2015-09-17 10:56:31 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1356543003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1356543003/1
3 years, 1 month ago (2015-09-17 13:34:01 UTC) #6
commit-bot: I haz the power
Try jobs failed on following builders: android on tryserver.webrtc (JOB_TIMED_OUT, no build URL) win_drmemory_light on ...
3 years, 1 month ago (2015-09-17 15:34:18 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1356543003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1356543003/1
3 years, 1 month ago (2015-09-18 08:27:34 UTC) #10
commit-bot: I haz the power
Committed patchset #1 (id:1)
3 years, 1 month ago (2015-09-18 08:29:16 UTC) #11
commit-bot: I haz the power
3 years, 1 month ago (2015-09-18 08:29:23 UTC) #12
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/061b79af6023b6caf9975be39fe53dd0ec3b7464
Cr-Commit-Position: refs/heads/master@{#9982}

Powered by Google App Engine
This is Rietveld 408576698