Remove ACM AudioCodingFeedback callback object and derived classes

webrtc/modules/audio_coding/main/test/APITest.cc

 /*
  *  Copyright (c) 2012 The WebRTC project authors. All Rights Reserved.
  *
  *  Use of this source code is governed by a BSD-style license
  *  that can be found in the LICENSE file in the root of the source
  *  tree. An additional intellectual property rights grant can be found
  *  in the file PATENTS.  All contributing project authors may
  *  be found in the AUTHORS file in the root of the source tree.
  */
 
@@ skipping 68 matching lines @@
       _sendVADModeA(VADNormal),
       _sendVADB(false),
       _sendDTXB(false),
       _sendVADModeB(VADNormal),
       _minDelayA(0),
       _minDelayB(0),
       _dotPositionA(0),
       _dotMoveDirectionA(1),
       _dotPositionB(39),
       _dotMoveDirectionB(-1),
-      _dtmfCallback(NULL),
       _vadCallbackA(NULL),
       _vadCallbackB(NULL),
       _apiTestRWLock(*RWLockWrapper::CreateRWLock()),
       _randomTest(false),
       _testNumA(0),
       _testNumB(1) {
   int n;
   for (n = 0; n < 32; n++) {
     _payloadUsed[n] = false;
   }
@@ skipping 18 matching lines @@
   DELETE_POINTER(_pullEventB);
   DELETE_POINTER(_processEventB);
   DELETE_POINTER(_apiEventB);
 
   _inFileA.Close();
   _outFileA.Close();
 
   _inFileB.Close();
   _outFileB.Close();
 
-  DELETE_POINTER(_dtmfCallback);
   DELETE_POINTER(_vadCallbackA);

[tlegrand-webrtc, 2015/09/18 08:36:55]

Why remove DELETE_POINTER(_vadCallbackB);?

[hlundin-webrtc, 2015/09/18 09:01:13]

Oh, bummer. Nice catch!
Done.

-  DELETE_POINTER(_vadCallbackB);
 
   delete &_apiTestRWLock;
 }
 
 int16_t APITest::SetUp() {
   CodecInst dummyCodec;
   int lastPayloadType = 0;
 
   int16_t numCodecs = _acmA->NumberOfCodecs();
   for (uint8_t n = 0; n < numCodecs; n++) {
@@ skipping 142 matching lines @@
     _randomTest = false;
     printf("\nPrint Tests (y/n)? ");
     EXPECT_TRUE(fgets(print, 10, stdin) != NULL);
     print[10] = '\0';
     if (strstr(print, "y") == NULL) {
       EXPECT_TRUE(freopen("APITest_log.txt", "w", stdout) != 0);
       _verbose = false;
     }
   }
 
-#ifdef WEBRTC_DTMF_DETECTION
-  _dtmfCallback = new DTMFDetector;
-#endif
   _vadCallbackA = new VADCallback;
   _vadCallbackB = new VADCallback;
 
   return 0;
 }
 
 bool APITest::PushAudioThreadA(void* obj) {
   return static_cast<APITest*>(obj)->PushAudioRunA();
 }
 
@@ skipping 872 matching lines @@
   CHECK_ERROR_MT(myACM->RegisterSendCodec(myCodec));
   myChannel->ResetStats();
   {
     WriteLockScoped wl(_apiTestRWLock);
     *thereIsEncoder = true;
   }
   Wait(500);
 }
 
 }  // namespace webrtc