Add RTC_ prefix to contructormagic macros.

Add RTC_ prefix to contructormagic macros.

We must remove dependency on Chromium, i.e. we can't use Chromium's base/logging.h. That means we need to define these macros in WebRTC also when doing Chromium builds. And this causes redefinition.

* DISALLOW_ASSIGN -> RTC_DISALLOW_ASSIGN
* DISALLOW_COPY_AND_ASSIGN -> RTC_DISALLOW_COPY_AND_ASSIGN
* DISALLOW_IMPLICIT_CONSTRUCTORS -> RTC_DISALLOW_IMPLICIT_CONSTRUCTORS

Related CL: https://codereview.webrtc.org/1335923002/

BUG=chromium:468375
NOTRY=true

Committed: https://crrev.com/3c089d751ede283e21e186885eaf705c3257ccd2
Cr-Commit-Position: refs/heads/master@{#9953}

[Henrik Grunell WebRTC, 2015-09-14 12:22:25]

henrikg@webrtc.org changed reviewers:
+ andrew@webrtc.org, tommi@webrtc.org

[tommi, 2015-09-14 14:13:50]

lgtm.  Can you update the description to include exactly what macros are being
changed (from -> to)?

[Henrik Grunell WebRTC, 2015-09-14 14:42:02]

On 2015/09/14 14:13:50, tommi (webrtc) wrote:
> lgtm.  Can you update the description to include exactly what macros are being
> changed (from -> to)?

Done.

[Andrew MacDonald, 2015-09-15 01:56:27]

lgtm

https://codereview.webrtc.org/1345433002/diff/1/webrtc/base/constructormagic.h
File webrtc/base/constructormagic.h (right):

https://codereview.webrtc.org/1345433002/diff/1/webrtc/base/constructormagic....
webrtc/base/constructormagic.h:19: #undef RTC_DISALLOW_COPY_AND_ASSIGN
We shouldn't need these #undefs now, right?

[Henrik Grunell WebRTC, 2015-09-16 11:07:54]

https://codereview.webrtc.org/1345433002/diff/1/webrtc/base/constructormagic.h
File webrtc/base/constructormagic.h (right):

https://codereview.webrtc.org/1345433002/diff/1/webrtc/base/constructormagic....
webrtc/base/constructormagic.h:19: #undef RTC_DISALLOW_COPY_AND_ASSIGN
On 2015/09/15 01:56:27, Andrew MacDonald wrote:
> We shouldn't need these #undefs now, right?

Nope, removed.

[Henrik Grunell WebRTC, 2015-09-16 11:15:29]

The CQ bit was checked by henrikg@webrtc.org

[Henrik Grunell WebRTC, 2015-09-16 11:15:30]

The patchset sent to the CQ was uploaded after l-g-t-m from tommi@webrtc.org,
andrew@webrtc.org
Link to the patchset: https://codereview.webrtc.org/1345433002/#ps40001 (title:
"Formatting fix.")

[commit-bot: I haz the power, 2015-09-16 11:15:37]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1345433002/40001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1345433002/40001

[commit-bot: I haz the power, 2015-09-16 12:11:55]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-09-16 12:11:56]

Try jobs failed on following builders:
  android_arm64_rel on tryserver.webrtc (JOB_FAILED,
http://build.chromium.org/p/tryserver.webrtc/builders/android_arm64_rel/build...)

[Henrik Grunell WebRTC, 2015-09-16 12:35:19]

The CQ bit was checked by henrikg@webrtc.org

[commit-bot: I haz the power, 2015-09-16 12:35:27]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1345433002/40001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1345433002/40001

[commit-bot: I haz the power, 2015-09-16 12:37:52]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2015-09-16 12:38:05]

Patchset 3 (id:??) landed as
https://crrev.com/3c089d751ede283e21e186885eaf705c3257ccd2
Cr-Commit-Position: refs/heads/master@{#9953}