Consolidate constructormagic macros with Chromium version and remove Chromium override.

Consolidate constructormagic macros with Chromium version and remove Chromium override.

Part of work removing dependency on Chromium's base.

Only adds "= delete". From https://codereview.chromium.org/1151443003 :
"This will guarantee the error to be at compile time, and not rely on the call visibility (private)."

In consequence of that change, fixed an illegal copy and removed a bunch of unused variables.

Depends on https://codereview.webrtc.org/1345433002/

BUG=chromium:468375
(in particular comment #37)
NOTRY=true

Committed: https://crrev.com/384194369b4be41912353631a68689129a49e58c
Cr-Commit-Position: refs/heads/master@{#9954}

[Henrik Grunell WebRTC, 2015-09-14 12:25:14]

henrikg@webrtc.org changed reviewers:
+ andrew@webrtc.org, tommi@webrtc.org

[tommi, 2015-09-14 14:11:33]

lgtm

[Andrew MacDonald, 2015-09-14 16:19:42]

Code looks good, but we should wait on this until your mailing list thread
arrives at a resolution, right?

[Henrik Grunell WebRTC, 2015-09-14 19:25:24]

On 2015/09/14 16:19:42, Andrew MacDonald wrote:
> Code looks good, but we should wait on this until your mailing list thread
> arrives at a resolution, right?

Yes, let's wait for that.

[Andrew MacDonald, 2015-09-15 01:51:44]

lgtm assuming no further concerns are brought up on your email thread.

[Henrik Grunell WebRTC, 2015-09-16 12:40:39]

The CQ bit was checked by henrikg@webrtc.org

[Henrik Grunell WebRTC, 2015-09-16 12:40:40]

The patchset sent to the CQ was uploaded after l-g-t-m from tommi@webrtc.org,
andrew@webrtc.org
Link to the patchset: https://codereview.webrtc.org/1342543004/#ps40001 (title:
"Rebase.")

[commit-bot: I haz the power, 2015-09-16 12:40:47]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1342543004/40001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1342543004/40001

[Henrik Grunell WebRTC, 2015-09-16 13:31:39]

The CQ bit was unchecked by henrikg@webrtc.org

[Henrik Grunell WebRTC, 2015-09-16 13:31:52]

The CQ bit was checked by henrikg@webrtc.org

[commit-bot: I haz the power, 2015-09-16 13:32:00]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1342543004/40001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1342543004/40001

[commit-bot: I haz the power, 2015-09-16 13:33:25]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2015-09-16 13:33:29]

Patchset 3 (id:??) landed as
https://crrev.com/384194369b4be41912353631a68689129a49e58c
Cr-Commit-Position: refs/heads/master@{#9954}

[Costent, 2015-10-14 13:09:06]

On 2015/09/16 13:33:29, commit-bot: I haz the power wrote:
> Patchset 3 (id:??) landed as
> https://crrev.com/384194369b4be41912353631a68689129a49e58c
> Cr-Commit-Position: refs/heads/master@{#9954}

`webrtc/overrides/webrtc/base/constructormagic.h` is still referenced in
`webrtc/base/base.gyp`.
See: https://codereview.webrtc.org/1394223003/

[Henrik Grunell WebRTC, 2015-10-14 13:48:04]

On 2015/10/14 13:09:06, Costent wrote:
> On 2015/09/16 13:33:29, commit-bot: I haz the power wrote:
> > Patchset 3 (id:??) landed as
> > https://crrev.com/384194369b4be41912353631a68689129a49e58c
> > Cr-Commit-Position: refs/heads/master@{#9954}
> 
> `webrtc/overrides/webrtc/base/constructormagic.h` is still referenced in
> `webrtc/base/base.gyp`.
> See: https://codereview.webrtc.org/1394223003/

I don't you have synced the latest code.
See
https://code.google.com/p/chromium/codesearch#chromium/src/third_party/webrtc...

[Costent, 2015-10-18 12:05:38]

On 2015/10/14 13:48:04, Henrik Grunell (webrtc) wrote:
> On 2015/10/14 13:09:06, Costent wrote:
> > On 2015/09/16 13:33:29, commit-bot: I haz the power wrote:
> > > Patchset 3 (id:??) landed as
> > > https://crrev.com/384194369b4be41912353631a68689129a49e58c
> > > Cr-Commit-Position: refs/heads/master@{#9954}
> > 
> > `webrtc/overrides/webrtc/base/constructormagic.h` is still referenced in
> > `webrtc/base/base.gyp`.
> > See: https://codereview.webrtc.org/1394223003/
> 
> I don't you have synced the latest code.
> See
>
https://code.google.com/p/chromium/codesearch#chromium/src/third_party/webrtc...

Indeed! My bad.