Add a name to the ProcessThread constructor.

Add a name to the ProcessThread constructor.

Helps differentiate between different instances when debugging.

Committed: https://crrev.com/847855b865987524be768c7771959f927db25808
Cr-Commit-Position: refs/heads/master@{#9927}

[stefan-webrtc, 2015-09-11 13:31:33]

The CQ bit was checked by stefan@webrtc.org to run a CQ dry run

[commit-bot: I haz the power, 2015-09-11 13:31:36]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1337003003/1
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1337003003/1

[stefan-webrtc, 2015-09-11 13:32:17]

stefan@webrtc.org changed reviewers:
+ henrika@webrtc.org, pbos@webrtc.org

[pbos-webrtc, 2015-09-11 13:37:22]

https://codereview.webrtc.org/1337003003/diff/1/webrtc/modules/utility/source...
File webrtc/modules/utility/source/process_thread_impl.h (right):

https://codereview.webrtc.org/1337003003/diff/1/webrtc/modules/utility/source...
webrtc/modules/utility/source/process_thread_impl.h:28: ProcessThreadImpl(const
std::string& thread_name);
explicit, and const char* if you wish since we'll use these with "" all the
time.

https://codereview.webrtc.org/1337003003/diff/1/webrtc/video/call.cc
File webrtc/video/call.cc (right):

https://codereview.webrtc.org/1337003003/diff/1/webrtc/video/call.cc#newcode139
webrtc/video/call.cc:139:
module_process_thread_(ProcessThread::Create("ProcessThread")),
ModuleProcessThread or ModuleThread

[stefan-webrtc, 2015-09-11 13:43:54]

https://codereview.webrtc.org/1337003003/diff/1/webrtc/modules/utility/source...
File webrtc/modules/utility/source/process_thread_impl.h (right):

https://codereview.webrtc.org/1337003003/diff/1/webrtc/modules/utility/source...
webrtc/modules/utility/source/process_thread_impl.h:28: ProcessThreadImpl(const
std::string& thread_name);
On 2015/09/11 13:37:22, pbos-webrtc wrote:
> explicit, and const char* if you wish since we'll use these with "" all the
> time.

Done.

https://codereview.webrtc.org/1337003003/diff/1/webrtc/video/call.cc
File webrtc/video/call.cc (right):

https://codereview.webrtc.org/1337003003/diff/1/webrtc/video/call.cc#newcode139
webrtc/video/call.cc:139:
module_process_thread_(ProcessThread::Create("ProcessThread")),
On 2015/09/11 13:37:22, pbos-webrtc wrote:
> ModuleProcessThread or ModuleThread

Done.

[pbos-webrtc, 2015-09-11 13:45:46]

lgtm

[henrika_webrtc, 2015-09-11 14:52:47]

LGTM

[stefan-webrtc, 2015-09-11 15:58:55]

The CQ bit was checked by stefan@webrtc.org

[commit-bot: I haz the power, 2015-09-11 15:59:05]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1337003003/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1337003003/20001

[commit-bot: I haz the power, 2015-09-11 16:52:20]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2015-09-11 16:52:33]

Patchset 2 (id:??) landed as
https://crrev.com/847855b865987524be768c7771959f927db25808
Cr-Commit-Position: refs/heads/master@{#9927}

[tommi, 2015-09-12 09:49:31]

tommi@webrtc.org changed reviewers:
+ tommi@webrtc.org

[tommi, 2015-09-12 09:49:32]

nice! thanks for doing this. drive-by nits, but lgtm.

https://codereview.webrtc.org/1337003003/diff/20001/webrtc/modules/utility/so...
File webrtc/modules/utility/source/process_thread_impl.h (right):

https://codereview.webrtc.org/1337003003/diff/20001/webrtc/modules/utility/so...
webrtc/modules/utility/source/process_thread_impl.h:28: explicit
ProcessThreadImpl(const char* thread_name);
does using |const char*| here and not |const std::string&| mean that we expect
only static strings to be provided as names?  If so, then I think thread_name_
should be of type const char*.  If we want to allow dynamically changing names,
then I'd go with const std::string&.

https://codereview.webrtc.org/1337003003/diff/20001/webrtc/modules/utility/so...
webrtc/modules/utility/source/process_thread_impl.h:79: std::string
thread_name_;
if we stick with std::string, then I think we should make this const
std::string.

https://codereview.webrtc.org/1337003003/diff/20001/webrtc/modules/video_capt...
File webrtc/modules/video_capture/test/video_capture_unittest.cc (right):

https://codereview.webrtc.org/1337003003/diff/20001/webrtc/modules/video_capt...
webrtc/modules/video_capture/test/video_capture_unittest.cc:432: process_module_
= webrtc::ProcessThread::Create("ProcessThread");
nit: use "VideoCaptureExternalTest"?

[stefan-webrtc, 2015-09-14 11:42:54]

https://codereview.webrtc.org/1337003003/diff/20001/webrtc/modules/utility/so...
File webrtc/modules/utility/source/process_thread_impl.h (right):

https://codereview.webrtc.org/1337003003/diff/20001/webrtc/modules/utility/so...
webrtc/modules/utility/source/process_thread_impl.h:28: explicit
ProcessThreadImpl(const char* thread_name);
On 2015/09/12 09:49:32, tommi (webrtc) wrote:
> does using |const char*| here and not |const std::string&| mean that we expect
> only static strings to be provided as names?  If so, then I think thread_name_
> should be of type const char*.  If we want to allow dynamically changing
names,
> then I'd go with const std::string&.

I can live with only having static strings for this for now, as I don't see
anywhere we'd like to have dynamic naming.

https://codereview.webrtc.org/1337003003/diff/20001/webrtc/modules/utility/so...
webrtc/modules/utility/source/process_thread_impl.h:79: std::string
thread_name_;
On 2015/09/12 09:49:32, tommi (webrtc) wrote:
> if we stick with std::string, then I think we should make this const
> std::string.

Done.

https://codereview.webrtc.org/1337003003/diff/20001/webrtc/modules/video_capt...
File webrtc/modules/video_capture/test/video_capture_unittest.cc (right):

https://codereview.webrtc.org/1337003003/diff/20001/webrtc/modules/video_capt...
webrtc/modules/video_capture/test/video_capture_unittest.cc:432: process_module_
= webrtc::ProcessThread::Create("ProcessThread");
On 2015/09/12 09:49:32, tommi (webrtc) wrote:
> nit: use "VideoCaptureExternalTest"? 

Do you mean renaming the process thread to VideoCaptureExternalTest?