Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(116)

Unified Diff: webrtc/modules/utility/source/process_thread_impl.h

Issue 1337003003: Add a name to the ProcessThread constructor. (Closed) Base URL: https://chromium.googlesource.com/external/webrtc.git@master
Patch Set: Comments addressed. Created 5 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: webrtc/modules/utility/source/process_thread_impl.h
diff --git a/webrtc/modules/utility/source/process_thread_impl.h b/webrtc/modules/utility/source/process_thread_impl.h
index 1fd2bf3adc56125aec3d4b9f410a79e984db8e11..53b5d591a383e7b4f11848ef3057b13687540824 100644
--- a/webrtc/modules/utility/source/process_thread_impl.h
+++ b/webrtc/modules/utility/source/process_thread_impl.h
@@ -25,7 +25,7 @@ namespace webrtc {
class ProcessThreadImpl : public ProcessThread {
public:
- ProcessThreadImpl();
+ explicit ProcessThreadImpl(const char* thread_name);
tommi 2015/09/12 09:49:32 does using |const char*| here and not |const std::
stefan-webrtc 2015/09/14 11:42:53 I can live with only having static strings for thi
~ProcessThreadImpl() override;
void Start() override;
@@ -76,6 +76,7 @@ class ProcessThreadImpl : public ProcessThread {
// TODO(tommi): Support delayed tasks.
std::queue<ProcessTask*> queue_;
bool stop_;
+ std::string thread_name_;
tommi 2015/09/12 09:49:32 if we stick with std::string, then I think we shou
stefan-webrtc 2015/09/14 11:42:53 Done.
};
} // namespace webrtc

Powered by Google App Engine
This is Rietveld 408576698