Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(877)

Side by Side Diff: webrtc/modules/utility/source/process_thread_impl.h

Issue 1337003003: Add a name to the ProcessThread constructor. (Closed) Base URL: https://chromium.googlesource.com/external/webrtc.git@master
Patch Set: Created 5 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 /* 1 /*
2 * Copyright (c) 2011 The WebRTC project authors. All Rights Reserved. 2 * Copyright (c) 2011 The WebRTC project authors. All Rights Reserved.
3 * 3 *
4 * Use of this source code is governed by a BSD-style license 4 * Use of this source code is governed by a BSD-style license
5 * that can be found in the LICENSE file in the root of the source 5 * that can be found in the LICENSE file in the root of the source
6 * tree. An additional intellectual property rights grant can be found 6 * tree. An additional intellectual property rights grant can be found
7 * in the file PATENTS. All contributing project authors may 7 * in the file PATENTS. All contributing project authors may
8 * be found in the AUTHORS file in the root of the source tree. 8 * be found in the AUTHORS file in the root of the source tree.
9 */ 9 */
10 10
11 #ifndef WEBRTC_MODULES_UTILITY_SOURCE_PROCESS_THREAD_IMPL_H_ 11 #ifndef WEBRTC_MODULES_UTILITY_SOURCE_PROCESS_THREAD_IMPL_H_
12 #define WEBRTC_MODULES_UTILITY_SOURCE_PROCESS_THREAD_IMPL_H_ 12 #define WEBRTC_MODULES_UTILITY_SOURCE_PROCESS_THREAD_IMPL_H_
13 13
14 #include <list> 14 #include <list>
15 #include <queue> 15 #include <queue>
16 16
17 #include "webrtc/base/criticalsection.h" 17 #include "webrtc/base/criticalsection.h"
18 #include "webrtc/base/thread_checker.h" 18 #include "webrtc/base/thread_checker.h"
19 #include "webrtc/modules/utility/interface/process_thread.h" 19 #include "webrtc/modules/utility/interface/process_thread.h"
20 #include "webrtc/system_wrappers/interface/event_wrapper.h" 20 #include "webrtc/system_wrappers/interface/event_wrapper.h"
21 #include "webrtc/system_wrappers/interface/thread_wrapper.h" 21 #include "webrtc/system_wrappers/interface/thread_wrapper.h"
22 #include "webrtc/typedefs.h" 22 #include "webrtc/typedefs.h"
23 23
24 namespace webrtc { 24 namespace webrtc {
25 25
26 class ProcessThreadImpl : public ProcessThread { 26 class ProcessThreadImpl : public ProcessThread {
27 public: 27 public:
28 ProcessThreadImpl(); 28 ProcessThreadImpl(const std::string& thread_name);
pbos-webrtc 2015/09/11 13:37:22 explicit, and const char* if you wish since we'll
stefan-webrtc 2015/09/11 13:43:54 Done.
29 ~ProcessThreadImpl() override; 29 ~ProcessThreadImpl() override;
30 30
31 void Start() override; 31 void Start() override;
32 void Stop() override; 32 void Stop() override;
33 33
34 void WakeUp(Module* module) override; 34 void WakeUp(Module* module) override;
35 void PostTask(rtc::scoped_ptr<ProcessTask> task) override; 35 void PostTask(rtc::scoped_ptr<ProcessTask> task) override;
36 36
37 void RegisterModule(Module* module) override; 37 void RegisterModule(Module* module) override;
38 void DeRegisterModule(Module* module) override; 38 void DeRegisterModule(Module* module) override;
(...skipping 30 matching lines...) Expand all
69 rtc::CriticalSection lock_; // Used to guard modules_, tasks_ and stop_. 69 rtc::CriticalSection lock_; // Used to guard modules_, tasks_ and stop_.
70 70
71 rtc::ThreadChecker thread_checker_; 71 rtc::ThreadChecker thread_checker_;
72 const rtc::scoped_ptr<EventWrapper> wake_up_; 72 const rtc::scoped_ptr<EventWrapper> wake_up_;
73 rtc::scoped_ptr<ThreadWrapper> thread_; 73 rtc::scoped_ptr<ThreadWrapper> thread_;
74 74
75 ModuleList modules_; 75 ModuleList modules_;
76 // TODO(tommi): Support delayed tasks. 76 // TODO(tommi): Support delayed tasks.
77 std::queue<ProcessTask*> queue_; 77 std::queue<ProcessTask*> queue_;
78 bool stop_; 78 bool stop_;
79 std::string thread_name_;
79 }; 80 };
80 81
81 } // namespace webrtc 82 } // namespace webrtc
82 83
83 #endif // WEBRTC_MODULES_UTILITY_SOURCE_PROCESS_THREAD_IMPL_H_ 84 #endif // WEBRTC_MODULES_UTILITY_SOURCE_PROCESS_THREAD_IMPL_H_
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698