webrtc/examples/androidtests/src/org/appspot/apprtc/test/PeerConnectionClientTest.java - Issue 1306073003: Android: Remove VideoRenderer.Callbacks.canApplyRotation()

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: webrtc/examples/androidtests/src/org/appspot/apprtc/test/PeerConnectionClientTest.java

Issue 1306073003: Android: Remove VideoRenderer.Callbacks.canApplyRotation() (Closed) Base URL: https://chromium.googlesource.com/external/webrtc.git@master

Patch Set: Created 5 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« talk/app/webrtc/java/testcommon/src/org/webrtc/PeerConnectionTest.java ('K') | « talk/app/webrtc/java/testcommon/src/org/webrtc/PeerConnectionTest.java ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: webrtc/examples/androidtests/src/org/appspot/apprtc/test/PeerConnectionClientTest.java

diff --git a/webrtc/examples/androidtests/src/org/appspot/apprtc/test/PeerConnectionClientTest.java b/webrtc/examples/androidtests/src/org/appspot/apprtc/test/PeerConnectionClientTest.java

index 00a8187f9af427eac6e9aa5bca5a90f1db58094b..19e7e008b4af8ed2e4cc2cca9a5a8bdb3f9482bd 100644

--- a/webrtc/examples/androidtests/src/org/appspot/apprtc/test/PeerConnectionClientTest.java

+++ b/webrtc/examples/androidtests/src/org/appspot/apprtc/test/PeerConnectionClientTest.java

@@ -83,12 +83,6 @@ public class PeerConnectionClientTest extends InstrumentationTestCase

doneRendering = new CountDownLatch(expectedFrames);

}

- // TODO(guoweis): Remove this once chrome code base is updated.

- @Override

- public boolean canApplyRotation() {

- return false;

- }

guoweis_webrtc 2015/08/24 14:07:35 same here.

magjed_webrtc 2015/08/24 14:18:25 This is just a mock class. The renderFrame() below

guoweis_webrtc 2015/08/24 14:27:12 Let's at least put a comment here that since JNI i

magjed_webrtc 2015/08/24 14:41:56 I replaced width/height with rotatedWidth()/rotate

@Override

public synchronized void renderFrame(VideoRenderer.I420Frame frame) {

if (!renderFrameCalled) {