Android: Remove VideoRenderer.Callbacks.canApplyRotation()

webrtc/examples/androidtests/src/org/appspot/apprtc/test/PeerConnectionClientTest.java

 /*
  *  Copyright 2014 The WebRTC Project Authors. All rights reserved.
  *
  *  Use of this source code is governed by a BSD-style license
  *  that can be found in the LICENSE file in the root of the source
  *  tree. An additional intellectual property rights grant can be found
  *  in the file PATENTS.  All contributing project authors may
  *  be found in the AUTHORS file in the root of the source tree.
  */
 
@@ skipping 65 matching lines @@
       this.rendererName = rendererName;
       reset(expectedFrames);
     }
 
     // Resets render to wait for new amount of video frames.
     public synchronized void reset(int expectedFrames) {
       renderFrameCalled = false;
       doneRendering = new CountDownLatch(expectedFrames);
     }
 
-    // TODO(guoweis): Remove this once chrome code base is updated.
-    @Override
-    public boolean canApplyRotation() {
-      return false;
-    }
-

[guoweis_webrtc, 2015/08/24 14:07:35]

same here.

[magjed_webrtc, 2015/08/24 14:18:25]

This is just a mock class. The renderFrame() below does not use |frame| for
anything except logging.

[guoweis_webrtc, 2015/08/24 14:27:12]

Let's at least put a comment here that since JNI is not using
GetCopyWithRotationApplied, the incoming frame is not rotated correctly.

[magjed_webrtc, 2015/08/24 14:41:56]

I replaced width/height with rotatedWidth()/rotatedHeight(). It should behave
exactly the same.

     @Override
     public synchronized void renderFrame(VideoRenderer.I420Frame frame) {
       if (!renderFrameCalled) {
         if (rendererName != null) {
           Log.d(TAG, rendererName + " render frame: " + frame.width + " x " + frame.height);
         } else {
           Log.d(TAG, "Render frame: " + frame.width + " x " + frame.height);
         }
       }
       renderFrameCalled = true;
@@ skipping 327 matching lines @@
           localRenderer.waitForFramesRendered(WAIT_TIMEOUT));
       assertTrue("Remote video frames were not rendered after video restart.",
           remoteRenderer.waitForFramesRendered(WAIT_TIMEOUT));
     }
     pcClient.close();
     assertTrue(waitForPeerConnectionClosed(WAIT_TIMEOUT));
     Log.d(TAG, "testVideoSourceRestart done.");
   }
 
 }