Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(52)

Unified Diff: talk/app/webrtc/java/testcommon/src/org/webrtc/PeerConnectionTest.java

Issue 1306073003: Android: Remove VideoRenderer.Callbacks.canApplyRotation() (Closed) Base URL: https://chromium.googlesource.com/external/webrtc.git@master
Patch Set: Created 5 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: talk/app/webrtc/java/testcommon/src/org/webrtc/PeerConnectionTest.java
diff --git a/talk/app/webrtc/java/testcommon/src/org/webrtc/PeerConnectionTest.java b/talk/app/webrtc/java/testcommon/src/org/webrtc/PeerConnectionTest.java
index e7b24b17ba649c3e3988b997d890c457c76d80bb..9f16b8a6627f7672b58e0728aadece96633d28aa 100644
--- a/talk/app/webrtc/java/testcommon/src/org/webrtc/PeerConnectionTest.java
+++ b/talk/app/webrtc/java/testcommon/src/org/webrtc/PeerConnectionTest.java
@@ -138,12 +138,6 @@ public class PeerConnectionTest {
--expectedFramesDelivered;
}
- // TODO(guoweis): Remove this once chrome code base is updated.
- @Override
- public boolean canApplyRotation() {
- return false;
- }
-
guoweis_webrtc 2015/08/24 14:07:35 will frame come to this class be handled correctly
magjed_webrtc 2015/08/24 14:18:25 You can see the renderFrame() implementation right
public synchronized void expectSignalingChange(SignalingState newState) {
expectedSignalingChanges.add(newState);
}
@@ -454,12 +448,6 @@ public class PeerConnectionTest {
public void renderFrame(VideoRenderer.I420Frame frame) {
++numFramesDelivered;
}
-
- // TODO(guoweis): Remove this once chrome code base is updated.
- @Override
- public boolean canApplyRotation() {
- return false;
- }
}
private static VideoRenderer createVideoRenderer(

Powered by Google App Engine
This is Rietveld 408576698