Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(139)

Issue 1294393002: Fixed base time in TransportFeedback message writing. (Closed)

Created:
5 years, 4 months ago by sprang_webrtc
Modified:
5 years, 3 months ago
Reviewers:
stefan-webrtc
CC:
webrtc-reviews_webrtc.org, tterriberry_mozilla.com, stefan-webrtc, mflodman
Base URL:
https://chromium.googlesource.com/external/webrtc.git@master
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

Fixed base time in TransportFeedback message writing. Value was incorrectly truncated to 16 bits when serializing the message. Fixed, with added regression tests. BUG= Committed: https://crrev.com/c8a1cccd0a80b35a5b6846f6efe6082f96c29083 Cr-Commit-Position: refs/heads/master@{#9858}

Patch Set 1 #

Patch Set 2 : Removed GetBaseTime (dead code) #

Patch Set 3 : Constant overflow #

Unified diffs Side-by-side diffs Delta from patch set Stats (+26 lines, -7 lines) Patch
M webrtc/modules/rtp_rtcp/source/rtcp_packet/transport_feedback.h View 1 1 chunk +0 lines, -1 line 0 comments Download
M webrtc/modules/rtp_rtcp/source/rtcp_packet/transport_feedback.cc View 1 2 chunks +2 lines, -6 lines 0 comments Download
M webrtc/modules/rtp_rtcp/source/rtcp_packet/transport_feedback_unittest.cc View 1 2 1 chunk +24 lines, -0 lines 0 comments Download

Messages

Total messages: 14 (6 generated)
sprang_webrtc
5 years, 4 months ago (2015-08-18 15:34:46 UTC) #2
sprang_webrtc
Reassigning to stefan@
5 years, 3 months ago (2015-08-31 13:19:08 UTC) #4
stefan-webrtc
lgtm
5 years, 3 months ago (2015-09-03 11:32:26 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1294393002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1294393002/20001
5 years, 3 months ago (2015-09-03 13:59:57 UTC) #7
commit-bot: I haz the power
Try jobs failed on following builders: win on tryserver.webrtc (JOB_FAILED, http://build.chromium.org/p/tryserver.webrtc/builders/win/builds/9470)
5 years, 3 months ago (2015-09-03 14:10:40 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1294393002/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1294393002/40001
5 years, 3 months ago (2015-09-04 11:37:27 UTC) #12
commit-bot: I haz the power
Committed patchset #3 (id:40001)
5 years, 3 months ago (2015-09-04 11:38:18 UTC) #13
commit-bot: I haz the power
5 years, 3 months ago (2015-09-04 11:38:25 UTC) #14
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/c8a1cccd0a80b35a5b6846f6efe6082f96c29083
Cr-Commit-Position: refs/heads/master@{#9858}

Powered by Google App Engine
This is Rietveld 408576698