Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(91)

Unified Diff: webrtc/modules/rtp_rtcp/source/rtcp_packet/transport_feedback.cc

Issue 1294393002: Fixed base time in TransportFeedback message writing. (Closed) Base URL: https://chromium.googlesource.com/external/webrtc.git@master
Patch Set: Constant overflow Created 5 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: webrtc/modules/rtp_rtcp/source/rtcp_packet/transport_feedback.cc
diff --git a/webrtc/modules/rtp_rtcp/source/rtcp_packet/transport_feedback.cc b/webrtc/modules/rtp_rtcp/source/rtcp_packet/transport_feedback.cc
index b426887d06ee8c7dc2bd54ba2119f5f458a87133..fee634b383af4310f94042c544fff63ff2448884 100644
--- a/webrtc/modules/rtp_rtcp/source/rtcp_packet/transport_feedback.cc
+++ b/webrtc/modules/rtp_rtcp/source/rtcp_packet/transport_feedback.cc
@@ -526,12 +526,8 @@ uint16_t TransportFeedback::GetBaseSequence() const {
return base_seq_;
}
-int32_t TransportFeedback::GetBaseTime() const {
- return static_cast<int32_t>(base_time_ & 0x00FFFFFF);
-}
-
int64_t TransportFeedback::GetBaseTimeUs() const {
- return GetBaseTime() * kBaseScaleFactor;
+ return base_time_ * kBaseScaleFactor;
}
std::vector<TransportFeedback::StatusSymbol>
@@ -591,7 +587,7 @@ bool TransportFeedback::Create(uint8_t* packet,
*position += 2;
ByteWriter<int32_t, 3>::WriteBigEndian(&packet[*position],
- static_cast<int16_t>(base_time_));
+ static_cast<int32_t>(base_time_));
*position += 3;
packet[(*position)++] = feedback_seq_;

Powered by Google App Engine
This is Rietveld 408576698