Fixed base time in TransportFeedback message writing.

webrtc/modules/rtp_rtcp/source/rtcp_packet/transport_feedback_unittest.cc

 /*
  *  Copyright (c) 2015 The WebRTC project authors. All Rights Reserved.
  *
  *  Use of this source code is governed by a BSD-style license
  *  that can be found in the LICENSE file in the root of the source
  *  tree. An additional intellectual property rights grant can be found
  *  in the file PATENTS.  All contributing project authors may
  *  be found in the AUTHORS file in the root of the source tree.
  */
 
@@ skipping 371 matching lines @@
 
   // Too large negative delta.
   packet.reset(new TransportFeedback());
   packet->WithBase(0, 0);
   int64_t kMaxNegativeTimeDelta = std::numeric_limits<int16_t>::min() *
                                   TransportFeedback::kDeltaScaleFactor;
   EXPECT_FALSE(packet->WithReceivedPacket(
       1, kMaxNegativeTimeDelta - TransportFeedback::kDeltaScaleFactor));
   EXPECT_TRUE(packet->WithReceivedPacket(1, kMaxNegativeTimeDelta));
 
+  // Base time at maximum value.
+  int64_t kMaxBaseTime =
+      static_cast<int64_t>(TransportFeedback::kDeltaScaleFactor) * (1L << 8) *
+      ((1L << 23) - 1);
+  packet.reset(new TransportFeedback());
+  packet->WithBase(0, kMaxBaseTime);
+  packet->WithReceivedPacket(0, kMaxBaseTime);
+  // Serialize and de-serialize (verify 24bit parsing).
+  rtc::scoped_ptr<rtcp::RawPacket> raw_packet = packet->Build();
+  packet =
+      TransportFeedback::ParseFrom(raw_packet->Buffer(), raw_packet->Length());
+  EXPECT_EQ(kMaxBaseTime, packet->GetBaseTimeUs());
+
+  // Base time above maximum value.
+  int64_t kTooLargeBaseTime =
+      kMaxBaseTime + (TransportFeedback::kDeltaScaleFactor * (1L << 8));
+  packet.reset(new TransportFeedback());
+  packet->WithBase(0, kTooLargeBaseTime);
+  packet->WithReceivedPacket(0, kTooLargeBaseTime);
+  raw_packet = packet->Build();
+  packet =
+      TransportFeedback::ParseFrom(raw_packet->Buffer(), raw_packet->Length());
+  EXPECT_NE(kTooLargeBaseTime, packet->GetBaseTimeUs());
+
   // TODO(sprang): Once we support max length lower than RTCP length limit,
   // add back test for max size in bytes.
 }
 
 TEST(RtcpPacketTest, TransportFeedback_Padding) {
   const size_t kExpectedSizeBytes =
       kHeaderSize + kStatusChunkSize + kSmallDeltaSize;
   const size_t kExpectedSizeWords = (kExpectedSizeBytes + 3) / 4;
 
   TransportFeedback feedback;
@@ skipping 23 matching lines @@
                           ((kPaddingBytes + 3) / 4));
 
   rtc::scoped_ptr<TransportFeedback> parsed_packet(
       TransportFeedback::ParseFrom(mod_buffer, kExpectedSizeWithPadding));
   ASSERT_TRUE(parsed_packet.get() != nullptr);
   EXPECT_EQ(kExpectedSizeWords * 4, packet->Length());  // Padding not included.
 }
 
 }  // namespace
 }  // namespace webrtc