Issue 1228203002: Remove BaseSession::SignalNewDescription. It was only used by GTP and now just clutters the code.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1228203002: Remove BaseSession::SignalNewDescription. It was only used by GTP and now just clutters the code. (Closed)

Created:
5 years, 5 months ago by pthatcher1

Modified:
5 years, 5 months ago

Reviewers:
guoweis_webrtc, pbos-webrtc

CC:
webrtc-reviews_webrtc.org, interface-changes_webrtc.org, rwolff_gocast.it, yujie_mao (webrtc), Andrew MacDonald, tterriberry_mozilla.com, qiang.lu, niklas.enbom

Base URL:
https://chromium.googlesource.com/external/webrtc.git@master

Target Ref:
refs/pending/heads/master

Project:
webrtc

Visibility:
Public.

More Reviews

Description

Remove BaseSession::SignalNewDescription. It was only used by GTP and now just clutters the code. R=pbos@webrtc.org Committed: https://chromium.googlesource.com/external/webrtc/+/a6d2444c84004d10a5d8b8517bbd178600f8412f

Patch Set 1 #

Patch Set 2 : merge #

Patch Set 3 : fix tests #

Created: 5 years, 5 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+65 lines, -183 lines)			Patch
M	talk/app/webrtc/webrtcsession.h	View	1	1 chunk	+0 lines, -13 lines	0 comments	Download
M	talk/session/media/channel.cc	View	1	2 chunks	+0 lines, -23 lines	0 comments	Download
M	talk/session/media/channel_unittest.cc	View	1 2	4 chunks	+65 lines, -93 lines	0 comments	Download
M	webrtc/p2p/base/session.h	View	1	2 chunks	+0 lines, -5 lines	0 comments	Download
M	webrtc/p2p/base/session.cc	View	1	2 chunks	+0 lines, -49 lines	0 comments	Download

Messages

Total messages: 5 (1 generated)

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages

pthatcher1

I had to fix some unit tests. Please take a look at them, too.

5 years, 5 months ago (2015-07-10 00:55:17 UTC) #4

pthatcher1

5 years, 5 months ago (2015-07-10 04:26:50 UTC) #5

Message was sent while issue was closed.

Committed patchset #3 (id:40001) manually as
a6d2444c84004d10a5d8b8517bbd178600f8412f (presubmit successful).

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages