Remove BaseSession::SignalNewDescription. It was only used by GTP and now just clutters the code.

talk/session/media/channel.cc

 /*
  * libjingle
  * Copyright 2004 Google Inc.
  *
  * Redistribution and use in source and binary forms, with or without
  * modification, are permitted provided that the following conditions are met:
  *
  *  1. Redistributions of source code must retain the above copyright notice,
  *     this list of conditions and the following disclaimer.
  *  2. Redistributions in binary form must reproduce the above copyright notice,
@@ skipping 186 matching lines @@
     return false;
   }
 
   if (!SetDtlsSrtpCiphers(transport_channel(), false)) {
     return false;
   }
   if (rtcp() && !SetDtlsSrtpCiphers(rtcp_transport_channel(), true)) {
     return false;
   }
 
-  session_->SignalNewLocalDescription.connect(
-      this, &BaseChannel::OnNewLocalDescription);
-  session_->SignalNewRemoteDescription.connect(
-      this, &BaseChannel::OnNewRemoteDescription);
-
   // Both RTP and RTCP channels are set, we can call SetInterface on
   // media channel and it can set network options.
   media_channel_->SetInterface(this);
   return true;
 }
 
 void BaseChannel::Deinit() {
   media_channel_->SetInterface(NULL);
 }
 
@@ skipping 434 matching lines @@
   }
 
   // Push it down to the media channel.
   if (!rtcp) {
     media_channel_->OnPacketReceived(packet, packet_time);
   } else {
     media_channel_->OnRtcpReceived(packet, packet_time);
   }
 }
 
-void BaseChannel::OnNewLocalDescription(
-    BaseSession* session, ContentAction action) {
-  std::string error_desc;
-  if (!PushdownLocalDescription(
-          session->local_description(), action, &error_desc))  {
-    SetSessionError(session_, BaseSession::ERROR_CONTENT, error_desc);
-  }
-}
-
-void BaseChannel::OnNewRemoteDescription(
-    BaseSession* session, ContentAction action) {
-  std::string error_desc;
-  if (!PushdownRemoteDescription(
-          session->remote_description(), action, &error_desc))  {
-    SetSessionError(session_, BaseSession::ERROR_CONTENT, error_desc);
-  }
-}
-
 bool BaseChannel::PushdownLocalDescription(
     const SessionDescription* local_desc, ContentAction action,
     std::string* error_desc) {
   const ContentInfo* content_info = GetFirstContent(local_desc);
   const MediaContentDescription* content_desc =
       GetContentDescription(content_info);
   if (content_desc && content_info && !content_info->rejected &&
       !SetLocalContent(content_desc, action, error_desc)) {
     LOG(LS_ERROR) << "Failure in SetLocalContent with action " << action;
     return false;
@@ skipping 1808 matching lines @@
   return (data_channel_type_ == DCT_RTP);
 }
 
 void DataChannel::OnStreamClosedRemotely(uint32 sid) {
   rtc::TypedMessageData<uint32>* message =
       new rtc::TypedMessageData<uint32>(sid);
   signaling_thread()->Post(this, MSG_STREAMCLOSEDREMOTELY, message);
 }
 
 }  // namespace cricket